Repository navigation
Commit 6e494b3
pythongh-105623 Fix performance degradation in logging RotatingFileHandler (pythonGH-105887)
The check for whether the log file is a real file is expensive on NFS
filesystems. This commit reorders the rollover condition checking to
not do the file type check if the expected file size is less than the
rotation threshold.
(cherry picked from commit e9b4ec6)
Co-authored-by: Craig Robson <craig@zhatt.com>
Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>1 parent d5441f6 commit 6e494b3
2 files changed
Lines changed: 5 additions & 3 deletions
File tree
- Lib/logging
- Misc/NEWS.d/next/Library
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | 196 | | |
200 | 197 | | |
201 | 198 | | |
202 | 199 | | |
203 | 200 | | |
204 | 201 | | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
205 | 205 | | |
206 | 206 | | |
207 | 207 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
0 commit comments