Skip to content

Commit ab39d35

Browse files
zenspiderzenspider
committed
Turn off parallelism on stub and spec meta tests because they hit class methods (globals)
[git-p4: depot-paths = "//src/minitest/dev/": change = 12127]
1 parent 398e270 commit ab39d35

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎test/minitest/test_minitest_mock.rb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ def test_mock_called_via_send_with_args
362362
require "minitest/metametameta"
363363

364364
class TestMinitestStub < Minitest::Test
365-
parallelize_me!
365+
# Do not parallelize since we're calling stub on class methods
366366

367367
def setup
368368
super

‎test/minitest/test_minitest_spec.rb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -757,7 +757,7 @@ def test_it_wont_add_test_methods_to_children
757757
end
758758

759759
class TestMeta < MetaMetaMetaTestCase
760-
parallelize_me!
760+
# do not call parallelize_me! here because specs use register_spec_type globally
761761

762762
def util_structure
763763
y = z = nil

0 commit comments

Comments
 (0)