Skip to content

Correctly log unit test error logs #10120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kartik Raj (karrtikr) merged 3 commits into from
Feb 18, 2020
Merged

Correctly log unit test error logs #10120

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63629a8
Correctly log unit test error logs
Feb 13, 2020
16ee4d2
Remove "any"
Feb 18, 2020
81a6b5a
Use traceInfo
Feb 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/client/testing/unittest/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ export class TestManagerRunner implements ITestManagerRunner {
options.tests.summary.skipped = 0;
let failFast = false;
const testLauncherFile = path.join(EXTENSION_ROOT_DIR, 'pythonFiles', 'visualstudio_py_testlauncher.py');
this.server.on('error', (message: string, ...data: string[]) => traceError(`${message} ${data.join(' ')}`));
this.server.on('log', noop);
this.server.on('error', traceError);
this.server.on('log', (message: string, ...data: string[]) => traceError(`${message} ${data.join(' ')}`));
Comment thread
karrtikr marked this conversation as resolved.
Resolved
this.server.on('connect', noop);
this.server.on('start', noop);
this.server.on('result', (data: ITestData) => {
Expand Down