Extension enters duplicate data into local globalStorage sqlite db #17488

Activity

1. Matt Seddon (mattseddon)

   added

   bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bug

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   on Sep 22, 2021
2. Matt Seddon (mattseddon)

   changed the title [-]Extension enters erroneous data into local `globalState` sqlite db[/-] [+]Extension enters erroneous data into local `globalStorage` sqlite db[/+] on Sep 22, 2021
3. Brett Cannon (brettcannon)

   assigned

   Kartik Raj (karrtikr)

   on Sep 22, 2021
4. Brett Cannon (brettcannon)

   added

   triage

   and removed

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   on Sep 22, 2021
5. Kartik Raj (karrtikr)

   added

   investigatingWe are looking into the cause of the issueWe are looking into the cause of the issue

   and removed

   triage

   on Sep 22, 2021
6. karrtikr commented on Sep 22, 2021

   

   Kartik Raj (karrtikr)

   on Sep 22, 2021

   More actions

   Thanks for the bug report! We just wanted to quickly acknowledge we received it and we will triage this as soon as we can.

   👍React with 👍1Reacted by Matt Seddon
7. Kartik Raj (karrtikr)

   added

   area-internalLabel for non-user facing issuesLabel for non-user facing issues

   needs PR

   regressionBug didn't exist in a previous releaseBug didn't exist in a previous release

   importantIssue identified as high-priorityIssue identified as high-priority

   and removed

   investigatingWe are looking into the cause of the issueWe are looking into the cause of the issue

   on Oct 1, 2021
8. Kartik Raj (karrtikr)

   added this to the October 2021 milestone on Oct 2, 2021
9. 4 remaining items

   Load more
10. Kartik Raj (karrtikr)

    closed this as completedin #17598on Oct 4, 2021
11. mattseddon commented on Oct 5, 2021

    

    Matt Seddon (mattseddon)

    on Oct 5, 2021

    Author

    More actions

    Kartik Raj (@karrtikr) I have just tested this and it does appear to have made things better. I can see that PYTHON_EXTENSION_GLOBAL_STORAGE_KEYS has been deprecated:

    "PYTHON_EXTENSION_GLOBAL_STORAGE_KEYS": []
    

    I am still seeing duplicates being created in the PYTHON_GLOBAL_STORAGE_KEYS array though:

    	"PYTHON_GLOBAL_STORAGE_KEYS": [{
    		"key": "PYTHON_EXTENSION_GLOBAL_STORAGE_KEYS",
    		"defaultValue": []
    	}, {
    		"key": "PYTHON_ENV_INFO_CACHE"
    	}, {
    		"key": "PYTHON_EXTENSION_GLOBAL_STORAGE_KEYS",
    		"defaultValue": []
    	}, {
    		"key": "PYTHON_ENV_INFO_CACHE"
    	}, {
    		"key": "PYTHON_EXTENSION_GLOBAL_STORAGE_KEYS",
    		"defaultValue": []
    	}, {
    		"key": "PYTHON_ENV_INFO_CACHE"
    	}, {
    		"key": "SWITCH_LS"
    	}, {
    		"key": "isGlobalSettingCopiedKey",
    		"defaultValue": false
    	}, {
    		"key": "workspaceFolderKeysForWhichTheCopyIsDone_Key",
    		"defaultValue": []
    	}, {
    		"key": "PYTHON_EXTENSION_GLOBAL_STORAGE_KEYS",
    		"defaultValue": []
    	}, {
    		"key": "ShowBanner",
    		"defaultValue": true
    	}, {
    		"key": "JoinMailingListPrompt",
    		"defaultValue": false
    	}, {
    		"key": "PythonTensorBoardWebviewPreferredViewGroup",
    		"defaultValue": -1
    	}, {
    		"key": "INSIDERS_PROMPT_STATE_KEY",
    		"defaultValue": false
    	}, {
    		"key": "WORKSPACE_FOLDER_INTERPRETER_PATH_/Users/mattseddon/PP/example-get-started"
    	}, {
    		"key": "preferredGlobalPyInterpreter"
    	}, {
    		"key": "PYTHON_ENV_INFO_CACHE"
    	}]
    

    I don't think that you can close the ticket using the current fix.
12. Kartik Raj (karrtikr)

    reopened this on Oct 5, 2021
13. github-actions

    added

    triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

    on Oct 5, 2021
14. karrtikr commented on Oct 5, 2021

    

    Kartik Raj (karrtikr)

    on Oct 5, 2021

    Last edited by karrtikr

    More actions

    Thanks for reporting back. The VSIX I provided initially is actually outdated as PR got updated further, can you try https://github.com/microsoft/vscode-python/suites/3954255787/artifacts/99265047 which appears to be the latest VSIX on the PR. Alternatively, you can try Python: Switch to Insiders command and wait a bit to install the latest insiders version of the extension.

    👍React with 👍1Reacted by Matt Seddon
15. karrtikr commented on Oct 5, 2021

    

    Kartik Raj (karrtikr)

    on Oct 5, 2021

    More actions

    FYI I can verify there's still an issue with PYTHON_EXTENSION_GLOBAL_STORAGE_KEYS, however I expect the key PYTHON_ENV_INFO_CACHE to not appear multiple times.
16. mattseddon commented on Oct 5, 2021

    

    Matt Seddon (mattseddon)

    on Oct 5, 2021

    Author

    More actions

    I am also seeing the issue with PYTHON_EXTENSION_GLOBAL_STORAGE_KEYS. Maybe the other issue is coming from the first vsix that I installed. I have 4 entries now but it appears to be stable:

    [
      {
        "key": "INSIDERS_PROMPT_STATE_KEY",
        "defaultValue": false
      },
      {
        "key": "JoinMailingListPrompt",
        "defaultValue": false
      },
      {
        "key": "PYTHON_ENV_INFO_CACHE"
      },
      {
        "key": "PYTHON_ENV_INFO_CACHE"
      },
      {
        "key": "PYTHON_ENV_INFO_CACHE"
      },
      {
        "key": "PYTHON_ENV_INFO_CACHE"
      },
      {
        "key": "PYTHON_EXTENSION_GLOBAL_STORAGE_KEYS",
        "defaultValue": []
      },
      {
        "key": "PYTHON_EXTENSION_GLOBAL_STORAGE_KEYS",
        "defaultValue": []
      },
      {
        "key": "PYTHON_EXTENSION_GLOBAL_STORAGE_KEYS",
        "defaultValue": []
      },
      {
        "key": "PYTHON_EXTENSION_GLOBAL_STORAGE_KEYS",
        "defaultValue": []
      },
      {
        "key": "PYTHON_EXTENSION_GLOBAL_STORAGE_KEYS",
        "defaultValue": []
      },
      {
        "key": "PYTHON_EXTENSION_GLOBAL_STORAGE_KEYS",
        "defaultValue": []
      },
      {
        "key": "PYTHON_EXTENSION_GLOBAL_STORAGE_KEYS",
        "defaultValue": []
      },
      {
        "key": "PYTHON_EXTENSION_GLOBAL_STORAGE_KEYS",
        "defaultValue": []
      },
      {
        "key": "PYTHON_EXTENSION_GLOBAL_STORAGE_KEYS",
        "defaultValue": []
      },
      {
        "key": "PYTHON_EXTENSION_GLOBAL_STORAGE_KEYS",
        "defaultValue": []
      },
      {
        "key": "PythonTensorBoardWebviewPreferredViewGroup",
        "defaultValue": -1
      },
      {
        "key": "SWITCH_LS"
      },
      {
        "key": "ShowBanner",
        "defaultValue": true
      },
      {
        "key": "WORKSPACE_FOLDER_INTERPRETER_PATH_/Users/mattseddon/PP/example-get-started"
      },
      {
        "key": "isGlobalSettingCopiedKey",
        "defaultValue": false
      },
      {
        "key": "preferredGlobalPyInterpreter"
      },
      {
        "key": "workspaceFolderKeysForWhichTheCopyIsDone_Key",
        "defaultValue": []
      }
    ]
    

    The list of PYTHON_EXTENSION_GLOBAL_STORAGE_KEYS seems to be ever growing.
17. karrtikr commented on Oct 5, 2021

    

    Kartik Raj (karrtikr)

    on Oct 5, 2021

    Last edited by karrtikr

    More actions

    I see, thanks for confirming. You can use the command Python: Clear Internal Extension cache to clear this storage anytime as well.

    👍React with 👍1Reacted by Matt Seddon
18. Kartik Raj (karrtikr)

    removed

    triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

    on Oct 5, 2021
19. Kartik Raj (karrtikr)

    closed this as completedin #17627on Oct 5, 2021
20. karrtikr commented on Oct 5, 2021

    

    Kartik Raj (karrtikr)

    on Oct 5, 2021

    More actions

    Matt Seddon (@mattseddon) Can you please try https://github.com/microsoft/vscode-python/suites/3965062360/artifacts/99642505, thanks!

    👍React with 👍1Reacted by Matt Seddon
21. mattseddon commented on Oct 5, 2021

    

    Matt Seddon (mattseddon)

    on Oct 5, 2021

    Author

    More actions

    Kartik Raj (@karrtikr) that seems to have fixed the issue.

    🎉React with 🎉1Reacted by Kartik Raj
22. Kartik Raj (karrtikr)

    added

    verifiedVerification succeededVerification succeeded

    and removed

    verification-neededVerification of issue is requestedVerification of issue is requested

    on Oct 25, 2021
23. github-actions

    locked as resolved and limited conversation to collaborators on Nov 27, 2021