Skip to content

Remove old API from Python extension #13986

Closed
microsoft/vscode-python
#21702

Description

Kartik Raj (@karrtikr) /cc
I'll work on this in debt week.

Activity

  1. karrtikr commented on Jul 25, 2023

    @karrtikr
    Contributor

    Thanks, wasn't clear on whether APIs under datascience scope are meant to be private for Jupyter or not. If those are no longer used please remove them.

    image

    Ref: #13982

  2. DonJayamanne commented on Jul 25, 2023

    @DonJayamanne
    ContributorAuthor

    They are definitely private, hence they can be removed from your npm package (not useful for anyone else), I will remove the code from your repo after a review.

  3. eleanorjboyd commented on Aug 30, 2023

    @eleanorjboyd

    does this need to be verified?

  4. DonJayamanne commented on Aug 30, 2023

    @DonJayamanne
    ContributorAuthor

    I do not think so, we just deleted dead code from the repo

  5. locked as resolved and limited conversation to collaborators on Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

debtCode quality issues

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions