Skip to content

Python: OllamaChatClient does not implement service_url(), so server.address is reported as Unknown #9221

Description

OllamaChatClient does not override BaseChatClient.service_url(), so the base default "Unknown" ends up in the server.address attribute of chat spans.

OllamaEmbeddingClient already returns its host from service_url(), and the Anthropic, Bedrock, Gemini, Mistral and OpenAI chat-completion clients all implement it. The chat client already stores the host in self.host, so it can return that.

Part of the server attribute coverage gap mentioned in #6626. I have a small fix ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    pythonUsage: [Issues, PRs], Target: PythontriageUsage: [Issues], Target: All issues that still need to be triaged

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions