Skip to content

Commit dea6700

Browse files
committed
refactor tests
1 parent 0e12e7c commit dea6700

2 files changed

Lines changed: 30 additions & 29 deletions

File tree

‎atest/robot/libdoc/libdoc_resource.robot‎

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ Run Libdoc And Parse Model From HTML
4343
Run Libdoc And Parse Model From JSON
4444
[Arguments] ${args}
4545
Run Libdoc ${args} ${OUTJSON}
46-
Validate JSON spec ${OUTJSON}
46+
Validate JSON Spec ${OUTJSON}
4747
${model_string}= Get File ${OUTJSON}
4848
${MODEL} = Evaluate json.loads($model_string)
4949
Set Suite Variable ${MODEL}
@@ -57,14 +57,14 @@ Format Should Be
5757
Element Attribute Should Be ${LIBDOC} format ${format}
5858

5959
Doc Should Start With
60-
[Arguments] @{doc}
61-
${doc}= Catenate SEPARATOR=\n @{doc}
62-
Element Text Should Match ${LIBDOC} ${doc}* doc
60+
[Arguments] @{expected}
61+
VAR ${expected} @{expected} separator=\n
62+
Element Text Should Match ${LIBDOC} ${expected}* doc
6363

6464
Doc Should Be
65-
[Arguments] @{doc}
66-
${doc}= Catenate SEPARATOR=\n @{doc}
67-
Element Text Should Be ${LIBDOC} ${doc} doc
65+
[Arguments] @{expected}
66+
VAR ${expected} @{expected} separator=\n
67+
Element Text Should Be ${LIBDOC} ${expected} doc
6868

6969
Version Should Match
7070
[Arguments] ${version}
@@ -108,26 +108,26 @@ Should Have No Init
108108
Should Be Empty ${inits}
109109

110110
Init Doc Should Start With
111-
[Arguments] ${index} @{doc}
111+
[Arguments] ${index} @{expected}
112+
VAR ${expected} @{expected} separator=\n
112113
${inits}= Get Elements ${LIBDOC} xpath=inits/init
113-
${doc}= Catenate SEPARATOR= @{doc}
114114
${text} = Get Element Text ${inits}[${index}] xpath=doc
115-
Should Start With ${text} ${doc}
115+
Should Start With ${text} ${expected}
116116

117117
Init Doc Should Be
118-
[Arguments] ${index} @{doc}
118+
[Arguments] ${index} @{expected}
119+
VAR ${expected} @{expected} separator=\n
119120
${kws}= Get Elements ${LIBDOC} xpath=inits/init
120-
${doc}= Catenate SEPARATOR= @{doc}
121-
Element Text Should Be ${kws}[${index}] ${doc} xpath=doc
121+
Element Text Should Be ${kws}[${index}] ${expected} xpath=doc
122122

123123
Init Arguments Should Be
124124
[Arguments] ${index} @{expected}
125125
Verify Arguments Structure ${index} inits/init ${expected}
126126

127127
Keyword Name Should Be
128128
[Arguments] ${index} ${name}
129-
${elements}= Get Elements ${LIBDOC} xpath=keywords/kw
130-
Element Attribute Should Be ${elements}[${index}] name ${name}
129+
${kws}= Get Elements ${LIBDOC} xpath=keywords/kw
130+
Element Attribute Should Be ${kws}[${index}] name ${name}
131131

132132
Keyword Arguments Should Be
133133
[Arguments] ${index} @{expected}
@@ -185,10 +185,10 @@ Get Type
185185
END
186186
${type} = Get Element Attribute ${elem} name
187187
IF $elem.get('union') == 'true'
188-
${type} = Catenate SEPARATOR=${SPACE}|${SPACE} @{nested}
188+
VAR ${type} @{nested} separator=${SPACE}|${SPACE}
189189
ELSE IF $nested
190-
${args} = Catenate SEPARATOR=,${SPACE} @{nested}
191-
${type} = Set Variable ${type}\[${args}]
190+
VAR ${args} @{nested} separator=,${SPACE}
191+
VAR ${type} ${type}\[${args}]
192192
END
193193
RETURN ${type}
194194

@@ -209,23 +209,23 @@ Verify Argument Model
209209
Should Be Equal As Strings ${arg_model}[repr] ${expected_repr}
210210

211211
Keyword Doc Should Start With
212-
[Arguments] ${index} @{doc}
212+
[Arguments] ${index} @{expected}
213+
VAR ${expected} @{expected} separator=\n
213214
${kws}= Get Elements ${LIBDOC} xpath=keywords/kw
214-
${doc}= Catenate SEPARATOR=\n @{doc}
215215
${text}= Get Element Text ${kws}[${index}] xpath=doc
216-
Should Start With ${text} ${doc}
216+
Should Start With ${text} ${expected}
217217

218218
Keyword Doc Should Be
219-
[Arguments] ${index} @{doc}
219+
[Arguments] ${index} @{expected}
220+
VAR ${expected} @{expected} separator=\n
220221
${kws}= Get Elements ${LIBDOC} xpath=keywords/kw
221-
${doc}= Catenate SEPARATOR=\n @{doc}
222-
Element Text Should Be ${kws}[${index}] ${doc} xpath=doc
222+
Element Text Should Be ${kws}[${index}] ${expected} xpath=doc
223223

224224
Keyword Shortdoc Should Be
225-
[Arguments] ${index} @{doc}
225+
[Arguments] ${index} @{expected}
226+
VAR ${expected} @{expected} separator=\n
226227
${kws}= Get Elements ${LIBDOC} xpath=keywords/kw
227-
${doc}= Catenate SEPARATOR=\n @{doc}
228-
Element Text Should Be ${kws}[${index}] ${doc} xpath=shortdoc
228+
Element Text Should Be ${kws}[${index}] ${expected} xpath=shortdoc
229229

230230
Keyword Tags Should Be
231231
[Arguments] ${index} @{expected}
@@ -289,7 +289,7 @@ Remove Output Files
289289

290290
Should Be Equal Multiline
291291
[Arguments] ${actual} @{expected} ${start}=False
292-
${expected} = Catenate SEPARATOR=\n @{expected}
292+
VAR ${expected} @{expected} separator=\n
293293
IF not ${start}
294294
Should Be Equal As Strings ${actual} ${expected}
295295
ELSE

‎atest/robot/libdoc/python_library.robot‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ Spec version
3333

3434
Init Documentation
3535
Init Doc Should Start With 0
36-
... Telnet library can be imported with optional configuration parameters.\n\n
36+
... Telnet library can be imported with optional configuration parameters.
37+
...
3738
... Configuration parameters are used as default values when new\nconnections are
3839

3940
Init Arguments

0 commit comments

Comments
 (0)