Skip to content

Commit 6b8dede

Browse files
matthiasgoergensmatthiasgoergens
committed
Annotate two TSAN suppressions with their removal conditions
race:partial_vectorcall_fallback (python/cpython#128050): the race was fixed on the 3.14 branch on 2026-01-16 (python/cpython#143882, follow-up issue python/cpython#143880), so the suppression is most likely dead. It is retained regardless: the hermetic TSAN CPython tarball the workflow downloads is an unversioned "3.14.x" artefact (declared to Bazel as 3.14.3), so nothing pins which source revision it was built from, and a wrongly removed suppression halts the nightly TSAN suite (halt_on_error=1) while a stale one costs nothing. The annotation records the two conditions under which it can go: provenance pinned to a post-fix revision, or a deliberately triggered green TSAN run without it. race:func_set_name (python/cpython#154821): fixed on the 3.14 branch on 2026-07-29 (python/cpython#154831); same removal condition once a rebuilt tarball contains the fix.
1 parent 1f35b07 commit 6b8dede

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

‎tests/config/tsan-suppressions_3.14.txt‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@ race:llvm::RuntimeDyldELF::registerEHFrames
66
race:dnnl_sgemm
77

88
# https://github.com/python/cpython/issues/128050
9+
# Fixed on the 3.14 branch by https://github.com/python/cpython/pull/143882
10+
# (merged 2026-01-16). Remove once the hermetic TSAN CPython tarball is
11+
# known to be built from a revision containing that fix (the tarball URL is
12+
# an unversioned "3.14.x" name, so its upload date does not establish the
13+
# source revision), or after a deliberately triggered green TSAN run with
14+
# the suppression removed.
915
race:partial_vectorcall_fallback
1016

1117
# Races because the LAPACK and BLAS in our scipy isn't TSAN instrumented.
@@ -21,4 +27,7 @@ race:gemm_oncopy
2127
race:type_update_dict
2228

2329
# https://github.com/python/cpython/issues/154821
30+
# Fixed on the 3.14 branch by https://github.com/python/cpython/pull/154831
31+
# (merged 2026-07-29). Remove once the hermetic TSAN CPython tarball is
32+
# built from a revision containing that fix.
2433
race:func_set_name

0 commit comments

Comments
 (0)