Skip to content

Boxplot fix median line extending past box boundaries #19409 #26462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timhoffm merged 11 commits into from
Aug 21, 2023
Merged

Boxplot fix median line extending past box boundaries #19409 #26462

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
53f5132
Set default `capstyle` to `butt`
kidkoder432 Aug 7, 2023
5d0a323
fix typo
kidkoder432 Aug 7, 2023
67d26cc
Remove `venv/` in ignore list
kidkoder432 Aug 7, 2023
6571818
fix formatting & remove capstyle in default params
kidkoder432 Aug 10, 2023
b1d8b51
fix NoneType error test failure
kidkoder432 Aug 12, 2023
0a9d0f8
fix formatting
kidkoder432 Aug 12, 2023
d1ba031
Fixed tests to use `butt` capstyle
kidkoder432 Aug 15, 2023
f2fdc2c
fixed pdf test failures
kidkoder432 Aug 19, 2023
8536a35
Update .gitignore
kidkoder432 Aug 19, 2023
0f2dee1
Update _axes.py
kidkoder432 Aug 19, 2023
0e98cd8
Force dash_capstyle to butt (unless specified)
kidkoder432 Aug 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
*.swp
.idea
.vscode/

Comment thread
kidkoder432 marked this conversation as resolved.
Resolved
# Compiled source #
###################
*.a
Expand Down
2 changes: 1 addition & 1 deletion lib/matplotlib/axes/_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4095,7 +4095,7 @@ def bxp(self, bxpstats, positions=None, widths=None, vert=True,

capwidths : float or array-like, default: None
Either a scalar or a vector and sets the width of each cap.
The default is ``0.5*(with of the box)``, see *widths*.
The default is ``0.5*(width of the box)``, see *widths*.
Comment thread
rcomer marked this conversation as resolved.
Resolved

vert : bool, default: True
If `True` (default), makes the boxes vertical.
Expand Down
2 changes: 1 addition & 1 deletion lib/matplotlib/lines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ def __init__(self, xdata, ydata, *,
markerfacecoloralt='none',
fillstyle=None,
antialiased=None,
dash_capstyle=None,
dash_capstyle="butt",
Comment thread
rcomer marked this conversation as resolved.
Resolved
solid_capstyle=None,
dash_joinstyle=None,
solid_joinstyle=None,
Expand Down
8 changes: 8 additions & 0 deletions lib/matplotlib/tests/test_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3223,6 +3223,14 @@ def test_bxp_customwhisker():
whiskerprops=dict(linestyle='-', color='m', lw=3)))


@check_figures_equal()
def test_boxplot_median_bound_by_box(fig_test, fig_ref):
data = np.arange(3)
medianprops_test = {"linewidth": 12}
medianprops_ref = {**medianprops_test, "solid_capstyle": "butt"}
fig_test.subplots().boxplot(data, medianprops=medianprops_test)
fig_ref.subplots().boxplot(data, medianprops=medianprops_ref)

@image_comparison(['bxp_withnotch.png'],
remove_text=True,
savefig_kwarg={'dpi': 40},
Expand Down