Repository navigation
triplot, etc examples broken by merged PR #3182 #3199
Description
The recently merged PR #3182 removed 2 lines in each of the examples tricontour_demo.py, tripcolor_demo.py and triplot_demo.py. These lines needed to be altered, not removed. Some of the plots produced are clearly wrong, e.g.
General rules for developers:
- If you change an example script, run it before and after your changes to see if the output is the same.
- If someone submits a PR that touches 60 files just prior to a release, either park it until after the release or be very sure it doesn't break anything.
Activity
tacaswell commentedon Jul 8, 2014
I am almost inclined to revert both of those PRs.
ianthomas23 commentedon Jul 8, 2014
@tacaswell: I agree entirely. There is the danger that other errors have been introduced, and some unnecessary formatting changes have been committed as in #3183.
tacaswell commentedon Jul 9, 2014
Reverted both #3181 and #3182.
Everyone needs to chill about the spacing around operators.