You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Doc]: A few problems on Image resampling page #29541
I was reading this docs page to better understand the changes in #28061, and I noticed a few things I think need fixing:
Just before the "Down-sampling and modest up-sampling" header, it says "For both keyword arguments, Matplotlib has a default "antialiased"...", but that default is now auto.
Just before the "Up-sampling" header, the example is discussing how in the first panel, "floating point imprecision makes some of the data values just a bit less than zero or a bit more than 2.0, and they get assigned the under- or over- colors". I don't see that occurring in the first panel of the plot. I see this:
but I wonder if it's supposed to look more like this plot from #28061:
What I see currently in the docs is also what I get running the example locally, though. If what I see in the docs is intended,
In that same example, it says "In the following, the data in the upper 100 rows is exactly 0.0, and data in the inner circle is exactly 2.0." Aren't the values of exactly 0.0 in the outer circle, not the upper 100 rows?
Lastly, again in that example, "(interpolation set set to 'nearest')" has an extra "set".
In response to the original text regarding floating-point imprecision, I’ve added the following lines to clarify the behavior in the first panel of the example:
In this example, the data values are clipped at the edges of the color range. The interpolation uses the 'nearest' method, and as a result, no floating-point imprecision is visible in the first panel.
Please let me know if this revision accurately reflects the intended behavior or if further adjustments are needed.
Activity
jklymak commentedon Jan 28, 2025
For sure a few things probably changed after this page was written. Any help you could give with it would be appreciated!
SiddharthKarmokar commentedon Feb 3, 2025
In response to the original text regarding floating-point imprecision, I’ve added the following lines to clarify the behavior in the first panel of the example:
Please let me know if this revision accurately reflects the intended behavior or if further adjustments are needed.
DOC: Fix outdated text in image_resampling example