You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Once #25359 is merged, it should be rather straightforward to add support for \boldsymbol which basically does the same thing as \mathbfit but is maybe a more standard solution.
Proposed solution
Some inspiration can be taken from #22173 on how to add a new parsing element, although QuotedString should (most likely) not be used.
Hopefully, #25359 is merged soon, so maybe one can wait for a bit before adding it? It is possible to open a new PR as well and just state that it depends on #25359.
Discussion there seems to have centered around "do we wish to include amsmath things in the mathtext implementation or keep it 'pure latex', for simplicity and scoping".
That said, the barrier for amsmath is breached by \genfrac and \binom already, so that could be an argument for including \boldsymbol
However, the behavior of \boldsymbol is not quite the same as bfit as noted by @devRDhere.
My personal prior would be that if \boldsymbol is included, it should behave as close to the latex behavior as possible, and thus is not as simple as aliasing bfit, though the implementation may mirror bfit.
Activity
devRD commentedon Apr 8, 2023
Hi @oscargus,
I have a working patch for
boldsymbolin my local repository. Since #25359 is a dependency, I am unsure about opening a new PR.Also, for generating the tests for
boldsymbol, does it needalltests for thebaseline_images, or similar to #22173 adding a lightweight test is fine?oscargus commentedon Apr 9, 2023
Great!
I think a lightweight test is enough.
Hopefully, #25359 is merged soon, so maybe one can wait for a bit before adding it? It is possible to open a new PR as well and just state that it depends on #25359.
devRD commentedon Apr 11, 2023
As mentioned in the linked PR, these changes currently do not build without PR #25359.
ksunden commentedon Jun 7, 2023
Xref #1366
Discussion there seems to have centered around "do we wish to include amsmath things in the
mathtextimplementation or keep it 'pure latex', for simplicity and scoping".That said, the barrier for
amsmathis breached by\genfracand\binomalready, so that could be an argument for including\boldsymbolHowever, the behavior of
\boldsymbolis not quite the same asbfitas noted by @devRD here.My personal prior would be that if
\boldsymbolis included, it should behave as close to the latex behavior as possible, and thus is not as simple as aliasingbfit, though the implementation may mirrorbfit.oscargus commentedon Jun 7, 2023
There are more things that are from ams and other packages (especially symbols). I'd say add what is useful.