[ENH]: Make rubber band more visible #23969

Activity

1. komoto48g

   added

   New feature

   on Sep 20, 2022
2. QuLogic commented on Sep 20, 2022

   

   QuLogic

   on Sep 20, 2022

   Member

   More actions

   With what backend? The rubber band should be alternating black and white in most (but not all in 3.5.3, IIRC.)
3. anntzer commented on Sep 21, 2022

   

   anntzer

   on Sep 21, 2022

   Contributor

   More actions

   IIRC it's wx which used that colored rectangle previously. Currently it doesn't draw the white dashes; seems straightforward enough to add that. Looking at other backends, I believe tk and macos also need the improvement.
   Marking as good first issue (but medium as you need to fiddle with GUI toolkits (and ObjC for the macos backend) -- it's not necessary for a PR to handle all backends at once).
4. anntzer

   added

   GUI: wx

   GUI: MacOSX

   GUI: tk

   🌱 Good first issueOpen a pull request against these issues if there are no active ones!Open a pull request against these issues if there are no active ones!

   on Sep 21, 2022
5. oscargus commented on Sep 21, 2022

   

   oscargus

   on Sep 21, 2022

   Member

   More actions

   The MacOS-backend has a separate issue with a bit of possibly useful details: #23777
6. oscargus commented on Sep 21, 2022

   

   oscargus

   on Sep 21, 2022

   Last edited by oscargus

   Member

   More actions

   For wx one can add the following line

               drawDC.DrawLineList(
                   [(x0, y0, x1, y0), (x1, y0, x1, y1),
                    (x0, y0, x0, y1), (x0, y1, x1, y1)],
                   wx.Pen('WHITE', 1, wx.PENSTYLE_SOLID))

   before
   

   matplotlib/lib/matplotlib/backends/backend_wx.py

   Lines 629 to 632 in 4a62222

   	drawDC.DrawLineList(
   	[(x0, y0, x1, y0), (x1, y0, x1, y1),
   	(x0, y0, x0, y1), (x0, y1, x1, y1)],
   	wx.Pen('BLACK', 1, wx.PENSTYLE_SHORT_DASH))

   
   to get a black-white-line as discussed in #23777

   wx does not support 0-length dashes, so one cannot start with a gap (as far as I can tell).

   Bonuses:

   • Only create the point-list once per call
   • Only create the pens once per CanvasBase instance.
7. komoto48g commented on Sep 21, 2022

   

   komoto48g

   on Sep 21, 2022

   Author

   More actions

   Thank you for your consideration of this issue. I tested on Windows 10 with matplotlib 3.5.3/WxAgg and TkAgg. The two seem slightly different:
   WxAgg => black dashed line
   TkAgg => black solid line
   The black and white line is also nice.
8. oscargus

   added this to the v3.6.1 milestone on Sep 23, 2022
9. QuLogic

   modified the milestones: v3.6.1, v3.6.2 on Oct 6, 2022
10. tacaswell

    closed this as completedin #23985on Oct 20, 2022