[Bug]: subplot parameter window appearing 1/4 size on macosx #21648

Activity

1. dstansby

   added

   GUI: MacOSX

   on Nov 16, 2021
2. dstansby commented on Nov 16, 2021

   

   dstansby

   on Nov 16, 2021

   MemberAuthor

   More actions

   Bisects to ab61cbe from #21365 (ping @QuLogic)
3. anntzer commented on Nov 16, 2021

   

   anntzer

   on Nov 16, 2021

   Contributor

   More actions

   I don't have a mac to try, but does replacing the entire body of configure_subplot() in _macosx.m by something like (untested, may be missing a semicolon or have some typos)

   -(void)configure_subplots:(id)sender
   {
       PyGILState_STATE gstate = PyGILState_Ensure();
       PyObject *mod = NULL, *base_class = NULL, *ret = NULL;
       if (!(mod = PyImport_ImportModule("matplotlib.backend_bases"))
           || !(base_class = PyObject_GetAttrString(mod, "NavigationToolbar2"))
           || !(ret = PyObject_CallMethod(base_class, "configure_subplots", toolbar))) {
           PyErr_Print();
       }
       Py_XDECREF(mod);
       Py_XDECREF(base_class);
       Py_XDECREF(ret);
       PyGILState_Release(gstate);
   }

   work? (effectively making it inherit the base class implementation, which is after all good enough for most other backends).
4. dstansby

   added this to the v3.5.1 milestone on Nov 16, 2021
5. QuLogic

   added a commit that references this issue on Nov 18, 2021

   Use standard subplot window in macosx backend

   ...

   This issue will close once commit f6495e1 is merged into the 'main' branch.

   f6495e1
6. QuLogic commented on Nov 18, 2021

   

   QuLogic

   on Nov 18, 2021

   Member

   More actions

   That seems to work, though I also parented the window so that it closes properly, and is slightly more linked to the plot window. I don't know if it fixes retina displays though.
7. QuLogic

   added 3 commits that reference this issue on Nov 19, 2021

   Use standard subplot window in macosx backend

   ...

   This issue will close once commit 4896d83 is merged into the 'main' branch.

   4896d83

   Use standard subplot window in macosx backend

   ...

   This issue will close once commit d1017e0 is merged into the 'main' branch.

   d1017e0

   Use standard subplot window in macosx backend

   ...

   This issue will close once commit b4392d3 is merged into the 'main' branch.

   b4392d3
8. greglucas

   closed this as completedin #21663on Nov 23, 2021