Support type checking with mypy #20504

Activity

1. rggjan

   added

   New feature

   on Jun 24, 2021
2. story645

   added

   status: duplicate

   on Jun 24, 2021
3. story645 commented on Jun 24, 2021

   

   story645

   on Jun 24, 2021

   Member

   More actions

   xref: #17991, #13798, #15926
4. story645

   added

   topic: typing

   on Jun 24, 2021
5. jklymak commented on Jun 24, 2021

   

   jklymak

   on Jun 24, 2021

   Member

   More actions

   As discussed on the call, Matplotlib may reconsider this after numpy has been through type hinting for a couple of releases.

   In the meantime, if anyone wants to release a separate package that supplies the hinting stubs, matplotlib would be be happy to support, perhaps even on the matplotlib root project (i.e. matplotlib/mpl-hinting) once it was shown to be generally useful.

   We will keep this open to track conversation.
6. rggjan commented on Jun 28, 2021

   

   rggjan

   on Jun 28, 2021

   Author

   More actions

   Sorry, didn't find the other issues, probably since I was only searching for mypy...
7. rggjan commented on Jun 28, 2021

   

   rggjan

   on Jun 28, 2021

   Author

   More actions

   Maybe some of this could be taken over:
   Mypy type stubs for NumPy, pandas, and Matplotlib
   ?

   It has the note:

   ⚠️ this project has mostly stopped development ⚠️

   The pandas team and the numpy team are both in the process of integrating type stubs into their codebases, and we don't see the point of competing with them.
8. tacaswell

   added this to the unassignedThis milestone has been deleted milestone on Jun 28, 2021
9. story645

   modified the milestones: unassignedThis milestone has been deleted, needs sorting on Oct 6, 2022
10. tmke8 commented on Dec 1, 2022

    

    tmke8

    on Dec 1, 2022

    Last edited by tmke8

    More actions

    The Pylance team at Microsoft seems to have produced pretty good type stubs for matplotlib: https://github.com/microsoft/python-type-stubs/tree/main/matplotlib

    ❤️React with ❤️1Reacted by Neil Girdhar
11. tacaswell commented on Dec 2, 2022

    

    tacaswell

    on Dec 2, 2022

    Last edited by tacaswell

    Member

    More actions

    Also see https://discourse.matplotlib.org/t/i-see-the-type-hints-from-vs-code-but-i-dont-understand-where-they-are-defined-in-the-code-in-github/22786/6
12. Dr-Irv commented on Jan 9, 2023

    

    Dr-Irv

    on Jan 9, 2023

    More actions

    The Pylance team at Microsoft seems to have produced pretty good type stubs for matplotlib: https://github.com/microsoft/python-type-stubs/tree/main/matplotlib

    With pandas, we created a pandas-stubs project https://github.com/pandas-dev/pandas-stubs that evolved as follows:

    1. We started with the stubs that Microsoft was maintaining as part of https://github.com/microsoft/python-type-stubs/
    2. In that project, we merged in tests from https://github.com/VirtusLab/pandas-stubs to provide a testing framework for the stubs.
    3. We met with the leader of the Microsoft project and VirtusLabs and agreed that the pandas team would start supplying the stubs, that the pandas stubs would be removed from the Microsoft project, and that VirtusLabs would deprecate their stubs.
    4. The pylance team now bundles the "official" pandas-stubs with pylance.

    I would suggest a similar path for matplotlib. Create a matplotlib-stubs project, and work with Microsoft to use their stubs as a starting point. You might also consider looking at what we are doing in pandas-stubs to create a testing methodology for correctness of the stubs.

    👍React with 👍2Reacted by Cristóbal Tapia and Samuel Carlsson

    ❤️React with ❤️2Reacted by Neil Girdhar and Samuel Carlsson
13. tacaswell

    closed this as completedin #24976on Mar 30, 2023
14. QuLogic

    modified the milestones: future releases, v3.8.0 on Mar 30, 2023