You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Marker sizes in Axes3D scatter plot are changing all the time #19787
The marker sizes that specified with s= argument in scatter function are wrong, and even worse, the markers are changing their sizes every time the plot is re-rendered (panning or resizing). It seems that the sizes are randomly reassigned to these markers.
The issue is that when we re-compute the 3D projection we resort the values based on their depth from the viewer (so markers "in the back" do not render "in the front"). We have a bunch of logic to make sure that the colors also track, but we need the same logic to be added to the size.
if you add color to this example you see that they keep their colors even if their sizes jump around.
There are enough coupled changes here (both to the mplot3d code and the colors), I do not think this is something we are going to be able to revert our way out of.
OK, figured out why this passed tests (at least as far as the size goes, the first render is right!):
It also looks like all of our tests with 3D scatter than do not have fixed color are using the figure comparison method so they are wrong together and we missed the color regression 😞 .
Activity
jklymak commentedon Mar 27, 2021
This bisects to e6d9cbb (#18189) Ping @tacaswell.
tacaswell commentedon Mar 28, 2021
Well, that is quite bad.
Thank you for the bisect @jklymak Looking at this now.
tacaswell commentedon Mar 28, 2021
The issue is that when we re-compute the 3D projection we resort the values based on their depth from the viewer (so markers "in the back" do not render "in the front"). We have a bunch of logic to make sure that the colors also track, but we need the same logic to be added to the size.
if you add color to this example you see that they keep their colors even if their sizes jump around.
tacaswell commentedon Mar 28, 2021
Attn @QuLogic This appears to be super broken.
I have been testing with:
which has both a color and size structure I can predict what should be.
tacaswell commentedon Mar 28, 2021
The color mapping was broken by 4c3d644 via #18480
There are enough coupled changes here (both to the mplot3d code and the colors), I do not think this is something we are going to be able to revert our way out of.
tacaswell commentedon Mar 28, 2021
OK, figured out why this passed tests (at least as far as the size goes, the first render is right!):
It also looks like all of our tests with 3D scatter than do not have fixed color are using the figure comparison method so they are wrong together and we missed the color regression 😞 .
tacaswell commentedon Mar 29, 2021
v3.3.4
#19812
tacaswell commentedon Mar 29, 2021
FIX: size and color rendering for Path3DCollection