Skip to content

Commit 516cb96

Browse files
committed
Fix missing return statement in onHandleIntent()
1 parent f9056d6 commit 516cb96

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

‎AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/handler/ServiceActionHandler.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,6 @@ private void addActionInOnHandleIntent(EIntentServiceHolder holder, ExecutableEl
9696
JVar extras = callActionBlock.decl(classes().BUNDLE, "extras");
9797
extras.init(holder.getOnHandleIntentIntent().invoke("getExtras"));
9898
JBlock extrasNotNullBlock = callActionBlock._if(extras.ne(_null()))._then();
99-
callActionBlock = extrasNotNullBlock;
100-
101-
List<JVar> extraFields = new ArrayList<JVar>();
10299

103100
// Extras params
104101
for (VariableElement param : methodParameters) {
@@ -123,8 +120,11 @@ private void addActionInOnHandleIntent(EIntentServiceHolder holder, ExecutableEl
123120
JVar extraField = extrasNotNullBlock.decl(extraParamClass, extraParamName, getExtraExpression);
124121
callActionInvocation.arg(extraField);
125122
}
123+
extrasNotNullBlock.add(callActionInvocation);
124+
} else {
125+
callActionBlock.add(callActionInvocation);
126126
}
127-
callActionBlock.add(callActionInvocation);
127+
callActionBlock._return();
128128
}
129129

130130
private void addActionToIntentBuilder(EIntentServiceHolder holder, ExecutableElement executableElement, String methodName, JFieldVar actionKeyField) {

0 commit comments

Comments
 (0)