A couple of possible issues with cA code #164

Activity

1. lamblin commented on Aug 11, 2016

   

   lamblin

   on Aug 11, 2016

   Member

   More actions

   First, when computing the loss due to the jacobian (line 211) shouldn't the integer division (//) be replaced by a a true division (/) ?

   Yes, this should be a true division. This seems to be an issue that has been introduced when trying to make the code compatible with python 3, but that line should not have been changed, since J (and then sum(J ** 2)) should be float.

   A pull request to fix that would be welcome.

   Second, the result of the previous line of code is a scalar. Then, why taking its mean when computing the cost function in next line of code (218) ?

   It is indeed unnecessary, but should not affect the computation speed. That fix would be welcome as well.

   Thanks for the report.
2. gsanroma commented on Aug 12, 2016

   

   gsanroma

   on Aug 12, 2016

   Author

   More actions

   Is there any tutorial on how to create pull requests ?
3. lamblin commented on Aug 12, 2016

   

   lamblin

   on Aug 12, 2016

   Member

   More actions

   You can have a look at http://deeplearning.net/software/theano/dev_start_guide.html, in particular http://deeplearning.net/software/theano/dev_start_guide.html#installation-and-configuration and http://deeplearning.net/software/theano/dev_start_guide.html#development-workflow, replacing Theano/Theano by lisa-lab/DeepLearningTutorials.