Skip to content

Commit b66c04e

Browse files
linesightclaude
linesight
and
claude
committed
ci: run the unit tests once, against the installed wheel
The harmonized workflows ran the suite twice: once pre-wheel against the staged build (PYTHONPATH) and again against the pip-installed wheel. Drop the pre-wheel run and keep only 'Test the built wheel' — it's the representative one (it's what users install, and it exercises the same compiled artifacts), matching the reviewer's preference and the old build_distrib.py behavior of testing the installed package. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 18a2d16 commit b66c04e

3 files changed

Lines changed: 0 additions & 15 deletions

File tree

‎.github/workflows/ci-linux.yml‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -125,11 +125,6 @@ jobs:
125125
cp -r build/artifacts/. cefpython3/
126126
chmod +x cefpython3/subprocess
127127
128-
- name: Run unit tests
129-
run: xvfb-run python unittests/_test_runner.py
130-
env:
131-
PYTHONPATH: ${{ github.workspace }}
132-
133128
- name: Build wheel
134129
run: python tools/build_distrib.py --dev
135130

‎.github/workflows/ci-macos.yml‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -139,11 +139,6 @@ jobs:
139139
PLIST
140140
echo "CFProcessPath=$BUNDLE_DIR/Contents/MacOS/python" >> $GITHUB_ENV
141141
142-
- name: Run unit tests
143-
run: python unittests/_test_runner.py
144-
env:
145-
PYTHONPATH: ${{ github.workspace }}
146-
147142
- name: Build wheel
148143
run: python tools/build_distrib.py --dev
149144

‎.github/workflows/ci-windows.yml‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -107,11 +107,6 @@ jobs:
107107
Copy-Item $_.FullName cefpython3/ -Recurse -Force
108108
}
109109
110-
- name: Run unit tests
111-
run: python unittests/_test_runner.py
112-
env:
113-
PYTHONPATH: ${{ github.workspace }}
114-
115110
- name: Build wheel
116111
run: python tools/build_distrib.py --dev
117112

0 commit comments

Comments
 (0)