Skip to content

inconsistent value types from uv_uptime #1294

Closed
Closed
inconsistent value types from uv_uptime#1294

Description

@refack
refack
opened on Apr 9, 2017

On Windows returned value is really a double (with fractions).
uptime = (double) (object_type->PerfTime.QuadPart - value) / (double) object_type->PerfFreq.QuadPart;

On others it's an integer (upcast to double):

struct timespec
	time_t  tv_sec    Seconds. 
	long    tv_nsec   Nanoseconds.

*uptime = now.tv_sec;

Activity

  1. gibfahn commented on Apr 9, 2017

    @gibfahn
    gibfahn
    on Apr 9, 2017

    Most recent change: 556fe1a (cc/ @bnoordhuis )

  2. refack
    added 3 commits that reference this issue on Apr 9, 2017

    !win: uv_uptime to actuality return a double

    44988a0

    !win: uv_uptime to actuality return a double

    3f273c1

    win: uv_uptime to return a floored double

    4b4a2d9
  3. cjihrig
    closed this as completedin 61a8d97on Apr 7, 2018
  4. addaleax
    added a commit that references this issue on Jan 29, 2025

    win: return a floored double from uv_uptime()

    61a8d97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions