You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 13, 2022. It is now read-only.
I might be missing something, not sure. But it looks like there is a missing puzzle piece. I mean, the method handle in the SubscriptionsManager class handles four cases:
connection init
start of subscription
data that is passed to subscription
stopping subscription
But the method handleConnectionInit despite returning message of the GQL_CONNECTION_ERROR type(if you throw an error in ON_CONNECT callback, for example), doesn't close the connection. And so you can still use the rest of the "methods": GQL_START, GQL_DATA, GQL_STOP without any problem even after the GQL_CONNECTION_ERROR was returned to the client.
My understanding is that, the GQL_CONNECTION_INIT should close the connection upon exception or otherwise mark it as authorized. And the other three "methods" should always check if connection is authorized.
Please let me know if I really miss something here.
I might be missing something, not sure. But it looks like there is a missing puzzle piece. I mean, the method
handlein theSubscriptionsManagerclass handles four cases:But the method
handleConnectionInitdespite returning message of theGQL_CONNECTION_ERRORtype(if you throw an error inON_CONNECTcallback, for example), doesn't close the connection. And so you can still use the rest of the "methods":GQL_START,GQL_DATA,GQL_STOPwithout any problem even after theGQL_CONNECTION_ERRORwas returned to the client.My understanding is that, the
GQL_CONNECTION_INITshould close the connection upon exception or otherwise mark it as authorized. And the other three "methods" should always check if connection is authorized.Please let me know if I really miss something here.