Repository navigation
check that key is valid on axis[key] #596
Description
Activity
I tried implementing this and fixed a few buggy tests thanks to this. I assume it would uncover less buggy code for users because they probably use the groups they define but... you never know.
I commented the checking code so far because a couple of tests are still failing with this and I am undecided how to fix them and besides a bugfix release does not seem like the right time to implement such a change.
Two class of test failures:
- tests which are expected to fail/raise but now raise "too soon" and thus the error message is not correct/the expected one. I hope it will be just a matter of catching the exception and re-raising it.
- a few tests revolving around the question of where we accept "query strings" and where we accept only raw values. For example:
I think I remember there were some cases where "query strings" are parsed within a list but I cannot find any anymore. I don't think we should, so that would only leave us with the single integer string being refused oddity. It's not really an ambiguity but that's weird anyway.
age = Axis('age=0..10') arr = ndtest(age) g = age[['2', '4', '7']] # the group creation worked before but fails with the check (but it failed when using the group) arr[g] # failed before g = age['2,4,7'] # works before and after LGroup('1', axis=age) # group creation worked before but fails with the check LGroup('1:3', axis=age) # works before and after
Currently, keys are only checked when used in an array, so when creating a group, it happily accepts keys which do not exist.
FWIW, it was done this way initially for two reasons:
related to #200. Please see the comments there.