broken in Node.js v23.5.0+

Hi,

This PR changed what appears in module.builtinModules (docs) such that prefix-only modules are now included.

This means for a module like node:test, the rule fails. I suppose the fix would be to exempt node:-prefixed module names from the check.

I can send a fix if you'd like.

chore(eslint): workaround for lint failure

Oh, just noticed the last sentence. Yes, if you would submit a PR, that would be awesome! If not, no worries; I'll see if I can fix it during this week

You may also want to consider using https://npmjs.com/is-core-module since it'll have much more reliable results than node's builtinModules list, and, it will work for an arbitrary node version, which for a project might not be the same one that's running eslint.

You may also want to consider using https://npmjs.com/is-core-module

I don't like how it uses two extra dependencies for something that simplistic

[...] it'll have much more reliable results than node's builtinModules list, and, it will work for an arbitrary node version, which for a project might not be the same one that's running eslint.

But this is a valid concern and should be looked into

¯\_(ツ)_/¯ it's clearly not that simple. up to you tho.

fix: support Node.js v23.5.0+

Created #13

Navigation Menu

Repository navigation

broken in Node.js v23.5.0+ #10

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

broken in Node.js v23.5.0+ #10

Description

Activity

kytta commented on May 13, 2025

ljharb commented on May 13, 2025

kytta commented on May 13, 2025

ljharb commented on May 13, 2025

boneskull commented on May 13, 2025

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions