Skip to content

Commit 4ee84e5

Browse files
ksundenImgBotApp
authored andcommitted
Review comments from Qulogic
Includes completion of rebase onto matplotlib#25580, fixing type hint
1 parent f44ae2b commit 4ee84e5

5 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎.github/workflows/mypy-stubtest.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ jobs:
2525
2626
- name: Run mypy stubtest
2727
run: |
28-
set -o pipefail
2928
# the ignore missing imports can be removed when typed cycler is released and used
3029
MPLBACKEND=agg python -m mypy.stubtest matplotlib --mypy-config-file pyproject.toml \
3130
--allowlist ci/mypy-stubtest-allowlist.txt

‎.github/workflows/reviewdog.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6666
run: |
6767
set -o pipefail
68-
# the ignore missing imports can be removed when typed cycler is released and used
68+
# The --ignore-missing-imports can be removed when typed cycler is released and used
6969
mypy --config pyproject.toml lib/matplotlib \
7070
--ignore-missing-imports \
7171
--follow-imports silent | \

‎lib/matplotlib/__init__.pyi‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ __all__ = [
88
"get_cachedir",
99
"get_data_path",
1010
"matplotlib_fname",
11+
"MatplotlibDeprecationWarning",
1112
"RcParams",
1213
"rc_params",
1314
"rc_params_from_file",

‎requirements/testing/mypy.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Extra pip requirements for the GitHub Actions flake8 build
1+
# Extra pip requirements for the GitHub Actions mypy build
22

33
mypy
44

‎tools/check_typehints.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
- Inheritance makes the set arithmetic harder when only loading AST
2929
- Attributes also make it more complicated when defined in init
3030
- Functions type hinted with ``overload`` are ignored for argument checking
31-
- Usually this means the implementation is is less strict in signature but will raise
31+
- Usually this means the implementation is less strict in signature but will raise
3232
if an invalid signature is used, type checking allows such errors to be caught by
3333
the type checker instead of at runtime.
3434
- Private attribute/functions are ignored

0 commit comments

Comments
 (0)