Skip to content

Commit 97d1bbd

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Create message variables for exceptions"
2 parents 75245d9 + c2b0cec commit 97d1bbd

3 files changed

Lines changed: 15 additions & 10 deletions

File tree

‎openstackclient/compute/v2/keypair.py‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,9 @@ def take_action(self, parsed_args):
5757
with open(os.path.expanduser(parsed_args.public_key)) as p:
5858
public_key = p.read()
5959
except IOError as e:
60-
raise exceptions.CommandError(
61-
"Key file %s not found: %s" % (parsed_args.public_key, e))
60+
msg = "Key file %s not found: %s"
61+
raise exceptions.CommandError(msg
62+
% (parsed_args.public_key, e))
6263

6364
keypair = compute_client.keypairs.create(
6465
parsed_args.name,

‎openstackclient/compute/v2/server.py‎

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -300,19 +300,22 @@ def take_action(self, parsed_args):
300300
raise exceptions.CommandError("Can't open '%s': %s" % (src, e))
301301

302302
if parsed_args.min > parsed_args.max:
303-
raise exceptions.CommandError("min instances should be <= "
304-
"max instances")
303+
msg = "min instances should be <= max instances"
304+
raise exceptions.CommandError(msg)
305305
if parsed_args.min < 1:
306-
raise exceptions.CommandError("min instances should be > 0")
306+
msg = "min instances should be > 0"
307+
raise exceptions.CommandError(msg)
307308
if parsed_args.max < 1:
308-
raise exceptions.CommandError("max instances should be > 0")
309+
msg = "max instances should be > 0"
310+
raise exceptions.CommandError(msg)
309311

310312
userdata = None
311313
if parsed_args.user_data:
312314
try:
313315
userdata = open(parsed_args.user_data)
314316
except IOError as e:
315-
raise exceptions.CommandError("Can't open '%s': %s" %
317+
msg = "Can't open '%s': %s"
318+
raise exceptions.CommandError(msg %
316319
(parsed_args.user_data, e))
317320

318321
block_device_mapping = dict(v.split('=', 1)
@@ -1082,8 +1085,8 @@ def take_action(self, parsed_args):
10821085
if p1 == p2:
10831086
server.change_password(p1)
10841087
else:
1085-
raise exceptions.CommandError(
1086-
"Passwords do not match, password unchanged")
1088+
msg = "Passwords do not match, password unchanged"
1089+
raise exceptions.CommandError(msg)
10871090

10881091

10891092
class ShowServer(show.ShowOne):

‎openstackclient/network/v2/network.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,8 @@ def take_action(self, parsed_args):
208208
if parsed_args.shared is not None:
209209
body['shared'] = parsed_args.shared
210210
if body == {}:
211-
raise exceptions.CommandError("Nothing specified to be set")
211+
msg = "Nothing specified to be set"
212+
raise exceptions.CommandError(msg)
212213
update_method = getattr(client, "update_network")
213214
update_method(_id, {'network': body})
214215
return

0 commit comments

Comments
 (0)