Skip to content

Commit 17a2c05

Browse files
krassowskikrassowski
authored
Backport PR #15811 on branch 3.6.x (Remove SO links, add more recent issue to FAQ) (#15824)
* Backport PR #15811: Remove SO links, add more recent issue to FAQ * Remove another SO link * Remove third copy of this link (really?)
1 parent ccc9082 commit 17a2c05

5 files changed

Lines changed: 12 additions & 12 deletions

File tree

‎docs/source/extension/ui_components.rst‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,7 @@ removed from the DOM, you’ll first need to clean it up:
111111
This cleanup step is not a special property of ``LabIcon``, but is
112112
instead needed for any React component that is rendered directly at the
113113
top level by ``ReactDOM``: failure to call ``unmountComponentAtNode``
114-
can result in a `memory
115-
leak <https://stackoverflow.com/a/48198011/425458>`__.
114+
can result in a memory leak.
116115

117116
How to create your own custom ``LabIcon``
118117
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

‎docs/source/getting_started/faq.rst‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,18 @@ Development
2222
- `How can you
2323
contribute? <https://github.com/jupyterlab/jupyterlab/blob/3.6.x/CONTRIBUTING.md>`__
2424
- :ref:`How can you extend or customize JupyterLab? <user_extensions>`
25-
- In the classic Notebook, `I could use custom Javascript outputted by a cell to programmatically
26-
control the Notebook <https://stackoverflow.com/a/32769976/907060>`__. Can I do the same thing in JupyterLab?
25+
- In the classic Notebook, I could use custom Javascript outputted by a cell to programmatically
26+
control the Notebook. Can I do the same thing in JupyterLab?
2727

2828
JupyterLab was built to support a wide variety of extensibility, including dynamic behavior based on notebook
2929
outputs. To access this extensibility, you should write a custom JupyterLab extension. If you would
3030
like trigger some behavior in response to the user executing some code in a notebook, you can output a custom
3131
mimetype (:ref:`rendermime`). We currently don't allow access to the JupyterLab
3232
API from the Javascript renderer, because this would tie the kernel and the notebook output to JupyterLab
33-
and make it hard for other frontends to support it.
34-
If you have comments or suggestions on changes here, please comment on `this issue <https://github.com/jupyterlab/jupyterlab/issues/4623>`__.
33+
and make it hard for other frontends to support it.
34+
For more discussion and potential alternative solutions, please see issues
35+
`#4623 <https://github.com/jupyterlab/jupyterlab/issues/4623>`__ and
36+
`#5789 <https://github.com/jupyterlab/jupyterlab/issues/5789>`__.
3537

3638

3739
Tips and Tricks

‎docs/source/user/extensions.rst‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,9 @@ rebuild, you can run the command:
104104
If you are rebuilding JupyterLab on Windows, you may encounter a
105105
``FileNotFoundError`` due to the default path length on Windows. Node
106106
modules are stored in a deeply nested directory structure, so paths can get
107-
quite long. If you have administrative access and are on Windows 8 or 10,
108-
you can update the registry setting using these instructions:
109-
https://stackoverflow.com/a/37528731.
107+
quite long. If you have administrative access and are on Windows 10 or newer
108+
you can enable long paths by adding a dedicated
109+
`registry key <https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation>`__.
110110

111111

112112
Listing installed extensions

‎packages/ui-components/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ ReactDOM.unmountComponentAtNode(elem);
9898
This cleanup step is not a special property of `LabIcon`, but is instead
9999
needed for any React component that is rendered directly at the top
100100
level by `ReactDOM`: failure to call `unmountComponentAtNode` can result
101-
in a [memory leak](https://stackoverflow.com/a/48198011/425458).
101+
in a memory leak.
102102

103103
## How to create your own custom `LabIcon`
104104

‎packages/ui-components/docs/source/labicon.rst‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,7 @@ removed from the DOM, you’ll first need to clean it up:
8484
This cleanup step is not a special property of ``LabIcon``, but is
8585
instead needed for any React component that is rendered directly at the
8686
top level by ``ReactDOM``: failure to call ``unmountComponentAtNode``
87-
can result in a `memory
88-
leak <https://stackoverflow.com/a/48198011/425458>`__.
87+
can result in a memory leak.
8988

9089
How to create your own custom ``LabIcon``
9190
-----------------------------------------

0 commit comments

Comments
 (0)