Skip to content

Port copy fix from Node.js core #918

Closed

Description

@RyanZim

Just opening an issue for nodejs/node#39372 (comment) so this doesn't get forgotten.

Activity

  1. added this to the 11.0.0 milestone on Sep 21, 2021
  2. RyanZim commented on Sep 21, 2021

    @RyanZim
    CollaboratorAuthor

    @manidlou FYI, will be working on pushing a new major release in the coming days with ESM support (refs #746 (comment)); any chance you could tackle this soon?

  3. rxliuli commented on Sep 25, 2021

    @rxliuli

    It seems not difficult to support esm/cjs at the same time through the build tool, why not do this? esm only can cause other problems. For example, some packages only support cjs, and some packages only support esm. This is very annoying. I can only package all dependencies into the bundle through the build tool.

  4. RyanZim commented on Sep 25, 2021

    @RyanZim
    CollaboratorAuthor

    @rxliuli We are planning to support both CJS and ESM; due to some special considerations, we can't just use an out of the box solution. See the issue for more details.

  5. RyanZim commented on Oct 20, 2022

    @RyanZim
    CollaboratorAuthor

    There's a real bug here, but I'm not sure if @bcoe fixed it correctly; see nodejs/node#39372 (comment)

  6. self-assigned this
    on Oct 20, 2022
  7. added a commit that references this issue on Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions