Skip to content

Commit 6c88569

Browse files
committed
Got rid of some unnecessary static_pointer_casts.
1 parent e11c816 commit 6c88569

4 files changed

Lines changed: 7 additions & 8 deletions

File tree

‎include/react/Event.h‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,9 @@
88

99
#include "react/detail/Defs.h"
1010

11-
#include <thread>
11+
#include <memory>
1212
#include <type_traits>
1313
#include <utility>
14-
#include <vector>
1514

1615
#include "react/Observer.h"
1716
#include "react/TypeTraits.h"
@@ -292,7 +291,7 @@ class TempEvents : public Events<D,E>
292291

293292
TOp StealOp()
294293
{
295-
return std::move(std::static_pointer_cast<NodeT>(ptr_)->StealOp());
294+
return std::move(reinterpret_cast<NodeT*>(ptr_.get())->StealOp());
296295
}
297296

298297
template <typename ... TArgs>

‎include/react/Signal.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ class TempSignal : public Signal<D,S>
241241

242242
TOp StealOp()
243243
{
244-
return std::move(std::static_pointer_cast<NodeT>(ptr_)->StealOp());
244+
return std::move(reinterpret_cast<NodeT*>(ptr_.get())->StealOp());
245245
}
246246
};
247247

‎include/react/detail/EventBase.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
#include "react/detail/Defs.h"
1010

11-
#include <memory>
1211
#include <utility>
1312

1413
#include "react/detail/ReactiveBase.h"
@@ -40,7 +39,8 @@ class EventStreamBase : public ReactiveBase<EventStreamNode<D,E>>
4039
void emit(T&& e) const
4140
{
4241
InputManager<D>::AddInput(
43-
*std::static_pointer_cast<EventSourceNode<D,E>>(ptr_), std::forward<T>(e));
42+
*reinterpret_cast<EventSourceNode<D,E>*>(ptr_.get()),
43+
std::forward<T>(e));
4444
}
4545
};
4646

‎include/react/detail/SignalBase.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
#include "react/detail/Defs.h"
1010

11-
#include <memory>
1211
#include <utility>
1312

1413
#include "react/detail/ReactiveBase.h"
@@ -46,7 +45,8 @@ class SignalBase : public ReactiveBase<SignalNode<D,S>>
4645
void setValue(T&& newValue) const
4746
{
4847
InputManager<D>::AddInput(
49-
*std::static_pointer_cast<VarNode<D,S>>(ptr_), std::forward<T>(newValue));
48+
*reinterpret_cast<VarNode<D,S>*>(ptr_.get()),
49+
std::forward<T>(newValue));
5050
}
5151
};
5252

0 commit comments

Comments
 (0)