Skip to content

Commit 2dd1d84

Browse files
irfanuddinahmadclaude
irfanuddinahmad
and
claude
committed
fix: address salman2013's review comments (release.yml, __init__.py, ci.yml)
- Bump PSR to v10.6.2 (v10.6.1 hits the GitPython 3.1.60 break upstream fixed in python-semantic-release/python-semantic-release#1477) - __init__.py: give __version__ a fallback instead of leaving it undefined - Restore ci.yml's push trigger alongside workflow_call Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent 383556f commit 2dd1d84

4 files changed

Lines changed: 5 additions & 2 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
name: Python CI
22

33
on:
4+
push:
5+
branches: [main]
46
workflow_call:
57
pull_request:
68
branches:

‎.github/workflows/release.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434

3535
- name: Python Semantic Release
3636
id: release
37-
uses: python-semantic-release/python-semantic-release@v10.6.1
37+
uses: python-semantic-release/python-semantic-release@v10.6.2
3838
with:
3939
github_token: ${{ secrets.OPENEDX_SEMANTIC_RELEASE_GITHUB_TOKEN }}
4040
git_committer_name: "github-actions"

‎.readthedocs.yaml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ version: 2
88
# Build documentation in the docs/ directory with Sphinx
99
sphinx:
1010
configuration: docs/conf.py
11+
fail_on_warning: true
1112

1213
build:
1314
os: ubuntu-lts-latest

‎src/openedx_core/__init__.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@
1010
try:
1111
__version__ = version("openedx-core")
1212
except PackageNotFoundError:
13-
pass
13+
__version__ = "unknown"

0 commit comments

Comments
 (0)