Skip to content

[Performance] Opening invite dialog causes full table re-render (Members Table Fully Refactored) #2806

Description

@RajuGangitla

Problem:
Opening the "Add Member" dialog triggers a full re-render of the entire MembersTable component tree. This was profiled with React Scan and confirmed at scale with 50 members/invitations.

Root Cause:
inviteDialogOpen state lives inside MembersTable. When the "+ Add" button is clicked, setInviteDialogOpen(true) updates state on the parent component, causing the entire table — all rows, cells, badges, and dropdowns — to re-render unnecessarily.
Same issue exists for changePasswordDialogOpen state.

Proposed Fix:
Basically Members Table Refactoring and Extract the invite button + dialog into an isolated InviteButton component so the open/close state is scoped locally and doesn't bubble up to MembersTable.

Proof (tested with 50 members) :

members.webm
Image

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions