Skip to content

Commit 69bcfca

Browse files
hodlinatorhodlinator
committed
fix(qa-tests): Bring back decoding of exception field
Partial revert of fab085c subprocess.run(..., text=True) is not sufficient to make the TimeoutExpired exception stop using byte buffers. This is a known issue, see: python/cpython#87597
1 parent fb43b2f commit 69bcfca

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎test/functional/feature_framework_startup_failures.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def _verify_startup_failure(self, test, internal_args, expected_exception):
4949
print("Unexpected child process timeout!\n"
5050
"WARNING: Timeouts like this halt execution of TestNode logic, "
5151
"meaning dangling bitcoind processes are to be expected.\n"
52-
f"<CHILD OUTPUT BEGIN>\n{e.output}\n<CHILD OUTPUT END>",
52+
f"<CHILD OUTPUT BEGIN>\n{e.output.decode("utf-8")}\n<CHILD OUTPUT END>",
5353
file=sys.stderr)
5454
raise
5555

0 commit comments

Comments
 (0)