Skip to content

Commit 14f978e

Browse files
committed
style(lint): disable deprecation warnings for ComponentFactory releated code
As there is currently no API available to replace it See angular/angular#44926
1 parent a3fa92a commit 14f978e

2 files changed

Lines changed: 12 additions & 0 deletions

File tree

‎projects/ng-dynamic-component/src/lib/io/io-factory.service.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ import { IoService } from './io.service';
1313
export class IoFactoryService {
1414
constructor(
1515
private differs: KeyValueDiffers,
16+
// TODO: Replace ComponentFactoryResolver once new API is created
17+
// @see https://github.com/angular/angular/issues/44926
18+
// eslint-disable-next-line deprecation/deprecation
1619
private cfr: ComponentFactoryResolver,
1720
@Inject(EventArgumentToken)
1821
private eventArgument: string,

‎projects/ng-dynamic-component/src/lib/io/io.service.ts‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@ export class IoService implements OnDestroy {
3939
private lastComponentInst: any = null;
4040
private lastInputChanges: SimpleChanges;
4141
private inputsDiffer = this.differs.find({}).create();
42+
// TODO: Replace ComponentFactory once new API is created
43+
// @see https://github.com/angular/angular/issues/44926
44+
// eslint-disable-next-line deprecation/deprecation
4245
private compFactory: ComponentFactory<any> | null = null;
4346
private outputsShouldDisconnect$ = new Subject<void>();
4447

@@ -70,6 +73,9 @@ export class IoService implements OnDestroy {
7073

7174
constructor(
7275
private differs: KeyValueDiffers,
76+
// TODO: Replace ComponentFactoryResolver once new API is created
77+
// @see https://github.com/angular/angular/issues/44926
78+
// eslint-disable-next-line deprecation/deprecation
7379
private cfr: ComponentFactoryResolver,
7480
@Inject(EventArgumentToken)
7581
private eventArgument: string,
@@ -255,6 +261,9 @@ export class IoService implements OnDestroy {
255261
return this._resolveChanges(changes);
256262
}
257263

264+
// TODO: Replace ComponentFactory once new API is created
265+
// @see https://github.com/angular/angular/issues/44926
266+
// eslint-disable-next-line deprecation/deprecation
258267
private _resolveCompFactory(): ComponentFactory<any> | null {
259268
try {
260269
try {

0 commit comments

Comments
 (0)