You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
CI Failure DoctorCI Failure - Run #22832374633 — Coverage regression in ExecutableNormalizedOperationFactory and QueryDirectivesImpl #4309
PR #4297 adds a new OperationDirectivesResolver directivesResolver field to ExecutableNormalizedOperationFactoryImpl (in src/main/java/graphql/normalized/ExecutableNormalizedOperationFactory.java) and calls directivesResolver.resolveDirectivesByName(...) inside createNormalizedQueryImpl(). This adds new code to ExecutableNormalizedOperationFactory that is not covered by existing tests for that class, causing a significant drop in line and method coverage.
QueryDirectivesImpl suffers a smaller coverage regression likely due to changes in how directive resolution is tested through the updated execution path.
Recommended Fix
Either update test-baseline.json to reflect the new coverage numbers (if the regressions are acceptable), OR
Add tests to ExecutableNormalizedOperationFactory-related test classes that exercise operations with directives (e.g., query @foo { field }) to recover coverage for the new directivesResolver.resolveDirectivesByName(...) call path in ExecutableNormalizedOperationFactory.java.
Activity