Skip to content

Unusable type signature for overload of graphql.schema.SchemaTraverser::depthFirst #4147

Closed

Description

@alf

Describe the bug

The following method declaration is only usable by graphql.schema.SchemaTraverser since the second arguments type is a private static inner class:

public TraverserResult depthFirst(final Traverser<GraphQLSchemaElement> traverser, final TraverserDelegateVisitor traverserDelegateVisitor, Collection<? extends GraphQLSchemaElement> roots);

I suspect that the signature should have been either private, or:

public TraverserResult depthFirst(final Traverser<GraphQLSchemaElement> traverser, final TraverserVisitor<GraphQLSchemaElement> traverserVisitor, Collection<? extends GraphQLSchemaElement> roots);

Activity

  1. marktech0813 commented on Nov 10, 2025

    @marktech0813
    Contributor

    Hi, Can I handle this issue?

  2. added a commit that references this issue on Dec 7, 2025
  3. github-actions commented on Jan 10, 2026

    @github-actions
    Contributor

    Hello, this issue has been inactive for 60 days, so we're marking it as stale. If you would like to continue this discussion, please comment within the next 30 days or we'll close the issue.

  4. alf commented on Jan 11, 2026

    @alf
    Author

    This issue was fixed by #4165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions