Repository navigation
Variables are coerced twice during an execution when a field validation instrumentation is active #2458
Description
Describe the bug
It looks like variables are coerced twice during an execution using graphql-java 16.2, once in execute and once in validateFieldsAndArguments. This breaks e.g. enums with non-default names.
Variables are first coerced here, then added to the execution context.
In FieldValidationSupport, the QueryTraverser is initialized with those variables from the execution context and coerces them again here.
To Reproduce
If you have an enum value defined like this
GraphQLEnumType.newEnum()
.name("MyEnum")
.description("My enum with all lowercase names.")
.values(
MyEnum.values().map {
GraphQLEnumValueDefinition.newEnumValueDefinition()
.name(it.getLowerCaseName())
.value(it)
.build()
}
).build()the first coercion works correctly, but the second one fails.
Activity
dondonz commentedon Jul 19, 2021
Hi @jenssuhr,
I'm trying to investigate the issue but I can't reproduce the error. Could you please help me by expanding on your example?
Could you please paste here:
jenssuhr commentedon Jul 26, 2021
Hi, thanks for investigating! I'll try to add an example as soon as possible.
jenssuhr commentedon Jul 26, 2021
I just noticed that we're not using the field validation correctly. Instead of using
SimpleFieldValidationand adding rules, we were using a separateFieldValidationInstrumentationfor each rule and chaining them together usingChainedInstrumentation. Fixing that will probably also fix this issue.Thank you for your help!