Repository navigation
java.lang.UnsupportedOperationException FieldDefinition.Builder.inputValueDefinition #2099
Description
Describe the bug
In our codebase we are using FieldDefinition.Builder like:
builder.inputValueDefinition(inputValueDefinition);
with current master (2020-11-10T10-26-00-07ca7ee, commit 07ca7ee) we have:
java.lang.UnsupportedOperationException
at graphql.com.google.common.collect.ImmutableCollection.add(ImmutableCollection.java:246)
at graphql.language.FieldDefinition$Builder.inputValueDefinition(FieldDefinition.java:210)
IMHO the cause is that in the copy constructor we have this:
this.inputValueDefinitions = existing.getInputValueDefinitions();
whereas should be like this:
this.inputValueDefinitions = new ArrayList<>(existing.getInputValueDefinitions());
because it is a builder and it is supposed to be mutable.
To Reproduce
Use of FieldDefinition.Builder.
Activity
[-]java.lang.UnsupportedOperationException after using last commit of master [/-][+]java.lang.UnsupportedOperationException after using last commit of master (07ca7ee)[/+][-]java.lang.UnsupportedOperationException after using last commit of master (07ca7ee)[/-][+]java.lang.UnsupportedOperationException after using last commit of master [/+]andimarek commentedon Nov 10, 2020
thanks a lot @dfa1 ... we will have a look
[-]java.lang.UnsupportedOperationException after using last commit of master [/-][+]java.lang.UnsupportedOperationException FieldDefinition.Builder.inputValueDefinition[/+]dfa1 commentedon Nov 16, 2020
fixed by last merge on master, thanks!
NB: found few new breaking changes in the public API (do you need a separate ticket?)