Skip to content

PropertyDataFetcher::findPubliclyAccessibleMethod performance  #1012

Closed

Description

@rrva

PropertyDataFetcher::findPubliclyAccessibleMethod which calls Class::getMethod is one of the more expensive methods performance-wise I found when profiling a GraphQL API example project.

Perhaps there should be some caching of method handles?

Flame graph taken which shows getMethod cost

screen shot 2018-04-05 at 22 23 28

Activity

  1. rrva commented on Apr 5, 2018

    @rrva
    Author

    I guess graphql-java-tools uses reflectasm to make this better, but since graphql-java-tools lags behind in compatbility with dataloaders etc, I would prefer to only depend on graphql-java (and graphql-java-tools seems to have other performance issues...)

  2. added this to the 9.0 milestone on May 9, 2018
  3. rrva commented on May 11, 2018

    @rrva
    Author

    @bbakerman Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions