Skip to content

release-please bot is attempting the release of same version after every new merge #988

Closed
googleapis/repo-automation-bots
#2331

Description

@vi3k6i5

After every PR merge on github repo release-please bot is trying to do a release of an already released version.

Example:
Successful release of 2.2.1b2 : googleapis/python-spanner-django#687

still reattempted by bot:

googleapis/python-spanner-django#689
googleapis/python-spanner-django#690
Any idea what is causing this and how to resolve it ?

There is a whole list with 2.2.1b1 https://github.com/googleapis/python-spanner-django/pulls?q=is%3Apr+is%3Aclosed

  1. Is this a client library issue or a product issue?
  • Not sure, maybe just a client level issue in configuration or maybe a version name mismatch from the django client.
  1. Did someone already solve this?
  • NA
  1. Do you have a support contract?
  • NA

Environment details

  • OS: NA
  • Node.js version: NA
  • npm version: NA
  • release-please version: latest in production

Steps to reproduce

  1. Merge a commit to repo https://github.com/googleapis/python-spanner-django master branch.
  2. Release please bot will create a new release PR similar to this: chore: release 2.2.1b2 Delete LICENSE #690

Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!

Activity

  1. added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on Jul 30, 2021
  2. bcoe commented on Jul 30, 2021

    @bcoe

    We don't currently support pre-releases with the format 1.0.0b1, 1.0.0b2, etc. The syntax Node.js and Java use for this is to have the prerelease version after a hyphen:

    1.0.0-beta.1
    1.0.0-beta.2
    etc.
    

    Is 1.0.0b1 common syntax for Python?

  3. bcoe commented on Jul 30, 2021

    @bcoe

    @chingor13 @joeldodge79 another need for a custom version bumping strategy?

  4. chingor13 commented on Jul 30, 2021

    @chingor13
    Contributor

    @chingor13 @joeldodge79 another need for a custom version bumping strategy?

    Probably. This is related to @parthea's feature request and requires thought about how to signal the version bump. How do we signal whether the next version should be 1.0.0b2, 1.1.0b1, 1.0.0 or 1.1.0?

  5. tseaver commented on Aug 2, 2021

    @tseaver

    @bcoe PEP 440 describes X.YbZ as the "normal" form, and accepts some others such as X.Y-beta.Z which are expected to be normalized back to it by tooling.

    @chingor13 I would expect that release-please would stay with -b# unless / until a PR with Release-As: bumped it (i.e., no automation).

  6. bcoe commented on Aug 4, 2021

    @bcoe

    @vi3k6i5 I believe this should be corrected now, I believe before the fix this PR would have contained all changes since last non alpha or beta release:

    googleapis/python-spanner-django#698

  7. reopened this on Aug 5, 2021
  8. bcoe commented on Aug 5, 2021

    @bcoe

    release-please had to be rolled back due to an unrelated issue, I will close this issue once we re-land.

  9. bcoe commented on Aug 6, 2021

    @bcoe

    fix has been redeployed.

  10. alexanderankin commented on Apr 30, 2026

    @alexanderankin

    how is this supposed to be used? i can set a python version strategy somehow? sorry to revive a dead thread... we've been talked into using release-please over at testcontainers/testcontainers-python and I've been using npx -y release-please but i've been doing --release-as 4.15.0-rc1 but it has been published to pypi as 4.15.0rc1 (which is correct) because python follows pep 440 instead of semver (so the version we store in our pyproject.toml is actually illegal. perhaps everything is working as it should? should i read anything specific to improve my understanding?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions