Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

proto-plus introduces substantial overhead to interactions with pb. #222

Closed

Description

@crwilcox

Profiled/Verified: googleapis/python-pubsub#158

Suspected: googleapis/python-datastore#145

It seems that the use of proto-plus is introducing somewhere between 40-150% overhead to client libraries when using proto plus.

Activity

  1. added
    P2A nice-to-fix bug
    priority: p2Moderately-important priority. Fix may not be included in next release.
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    and removed
    🚨This issue needs some love.
    triage meI really want to be triaged.
    on Mar 30, 2021
  2. tseaver commented on Apr 14, 2021

    @tseaver
    Contributor

    Today I measured an order of magnitude slowdown for datastore (unmarshaling query results to entities).

  3. self-assigned this
    on May 10, 2021
  4. craiglabenz commented on Aug 6, 2021

    @craiglabenz

    Closing this, as the state of proto-plus performance optimizations is known to center around changing lines of code like this:

    my_proto_plus_object.some_attribute

    into this:

    my_proto_plus_object._pb.some_attribute

    to reclaim >= 90% of the lost performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2A nice-to-fix bugpriority: p2Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions