Skip to content

Commit 417e9e5

Browse files
gcf-owl-bot[bot]gcf-owl-bot[bot]
authored
fix: Add async context manager return types (#340)
* fix: Add async context manager return types chore: Mock return_value should not populate oneof message fields chore: Support snippet generation for services that only support REST transport chore: Update gapic-generator-python to v1.11.0 PiperOrigin-RevId: 545430278 Source-Link: googleapis/googleapis@601b532 Source-Link: googleapis/googleapis-gen@b3f18d0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 7b0117d commit 417e9e5

6 files changed

Lines changed: 12 additions & 32 deletions

File tree

‎packages/google-cloud-scheduler/google/cloud/scheduler_v1/services/cloud_scheduler/async_client.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1252,7 +1252,7 @@ async def list_locations(
12521252
# Done; return the response.
12531253
return response
12541254

1255-
async def __aenter__(self):
1255+
async def __aenter__(self) -> "CloudSchedulerAsyncClient":
12561256
return self
12571257

12581258
async def __aexit__(self, exc_type, exc, tb):

‎packages/google-cloud-scheduler/google/cloud/scheduler_v1beta1/services/cloud_scheduler/async_client.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1273,7 +1273,7 @@ async def list_locations(
12731273
# Done; return the response.
12741274
return response
12751275

1276-
async def __aenter__(self):
1276+
async def __aenter__(self) -> "CloudSchedulerAsyncClient":
12771277
return self
12781278

12791279
async def __aexit__(self, exc_type, exc, tb):

‎packages/google-cloud-scheduler/samples/generated_samples/snippet_metadata_google.cloud.scheduler.v1.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
],
99
"language": "PYTHON",
1010
"name": "google-cloud-scheduler",
11-
"version": "2.11.0"
11+
"version": "0.1.0"
1212
},
1313
"snippets": [
1414
{

‎packages/google-cloud-scheduler/samples/generated_samples/snippet_metadata_google.cloud.scheduler.v1beta1.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
],
99
"language": "PYTHON",
1010
"name": "google-cloud-scheduler",
11-
"version": "2.11.0"
11+
"version": "0.1.0"
1212
},
1313
"snippets": [
1414
{

‎packages/google-cloud-scheduler/tests/unit/gapic/scheduler_v1/test_cloud_scheduler.py‎

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1123,9 +1123,11 @@ async def test_list_jobs_async_pages():
11231123
RuntimeError,
11241124
)
11251125
pages = []
1126-
async for page_ in (
1126+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
1127+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
1128+
async for page_ in ( # pragma: no branch
11271129
await client.list_jobs(request={})
1128-
).pages: # pragma: no branch
1130+
).pages:
11291131
pages.append(page_)
11301132
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
11311133
assert page_.raw_page.next_page_token == token
@@ -1157,7 +1159,6 @@ def test_get_job(request_type, transport: str = "grpc"):
11571159
schedule="schedule_value",
11581160
time_zone="time_zone_value",
11591161
state=job.Job.State.ENABLED,
1160-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
11611162
)
11621163
response = client.get_job(request)
11631164

@@ -1402,7 +1403,6 @@ def test_create_job(request_type, transport: str = "grpc"):
14021403
schedule="schedule_value",
14031404
time_zone="time_zone_value",
14041405
state=gcs_job.Job.State.ENABLED,
1405-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
14061406
)
14071407
response = client.create_job(request)
14081408

@@ -1657,7 +1657,6 @@ def test_update_job(request_type, transport: str = "grpc"):
16571657
schedule="schedule_value",
16581658
time_zone="time_zone_value",
16591659
state=gcs_job.Job.State.ENABLED,
1660-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
16611660
)
16621661
response = client.update_job(request)
16631662

@@ -2132,7 +2131,6 @@ def test_pause_job(request_type, transport: str = "grpc"):
21322131
schedule="schedule_value",
21332132
time_zone="time_zone_value",
21342133
state=job.Job.State.ENABLED,
2135-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
21362134
)
21372135
response = client.pause_job(request)
21382136

@@ -2377,7 +2375,6 @@ def test_resume_job(request_type, transport: str = "grpc"):
23772375
schedule="schedule_value",
23782376
time_zone="time_zone_value",
23792377
state=job.Job.State.ENABLED,
2380-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
23812378
)
23822379
response = client.resume_job(request)
23832380

@@ -2622,7 +2619,6 @@ def test_run_job(request_type, transport: str = "grpc"):
26222619
schedule="schedule_value",
26232620
time_zone="time_zone_value",
26242621
state=job.Job.State.ENABLED,
2625-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
26262622
)
26272623
response = client.run_job(request)
26282624

@@ -3200,7 +3196,6 @@ def test_get_job_rest(request_type):
32003196
schedule="schedule_value",
32013197
time_zone="time_zone_value",
32023198
state=job.Job.State.ENABLED,
3203-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
32043199
)
32053200

32063201
# Wrap the value into a proper Response obj
@@ -3529,7 +3524,6 @@ def test_create_job_rest(request_type):
35293524
schedule="schedule_value",
35303525
time_zone="time_zone_value",
35313526
state=gcs_job.Job.State.ENABLED,
3532-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
35333527
)
35343528

35353529
# Wrap the value into a proper Response obj
@@ -3930,7 +3924,6 @@ def test_update_job_rest(request_type):
39303924
schedule="schedule_value",
39313925
time_zone="time_zone_value",
39323926
state=gcs_job.Job.State.ENABLED,
3933-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
39343927
)
39353928

39363929
# Wrap the value into a proper Response obj
@@ -4513,7 +4506,6 @@ def test_pause_job_rest(request_type):
45134506
schedule="schedule_value",
45144507
time_zone="time_zone_value",
45154508
state=job.Job.State.ENABLED,
4516-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
45174509
)
45184510

45194511
# Wrap the value into a proper Response obj
@@ -4784,7 +4776,6 @@ def test_resume_job_rest(request_type):
47844776
schedule="schedule_value",
47854777
time_zone="time_zone_value",
47864778
state=job.Job.State.ENABLED,
4787-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
47884779
)
47894780

47904781
# Wrap the value into a proper Response obj
@@ -5058,7 +5049,6 @@ def test_run_job_rest(request_type):
50585049
schedule="schedule_value",
50595050
time_zone="time_zone_value",
50605051
state=job.Job.State.ENABLED,
5061-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
50625052
)
50635053

50645054
# Wrap the value into a proper Response obj

‎packages/google-cloud-scheduler/tests/unit/gapic/scheduler_v1beta1/test_cloud_scheduler.py‎

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1123,9 +1123,11 @@ async def test_list_jobs_async_pages():
11231123
RuntimeError,
11241124
)
11251125
pages = []
1126-
async for page_ in (
1126+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
1127+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
1128+
async for page_ in ( # pragma: no branch
11271129
await client.list_jobs(request={})
1128-
).pages: # pragma: no branch
1130+
).pages:
11291131
pages.append(page_)
11301132
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
11311133
assert page_.raw_page.next_page_token == token
@@ -1158,7 +1160,6 @@ def test_get_job(request_type, transport: str = "grpc"):
11581160
time_zone="time_zone_value",
11591161
state=job.Job.State.ENABLED,
11601162
legacy_app_engine_cron=True,
1161-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
11621163
)
11631164
response = client.get_job(request)
11641165

@@ -1407,7 +1408,6 @@ def test_create_job(request_type, transport: str = "grpc"):
14071408
time_zone="time_zone_value",
14081409
state=gcs_job.Job.State.ENABLED,
14091410
legacy_app_engine_cron=True,
1410-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
14111411
)
14121412
response = client.create_job(request)
14131413

@@ -1666,7 +1666,6 @@ def test_update_job(request_type, transport: str = "grpc"):
16661666
time_zone="time_zone_value",
16671667
state=gcs_job.Job.State.ENABLED,
16681668
legacy_app_engine_cron=True,
1669-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
16701669
)
16711670
response = client.update_job(request)
16721671

@@ -2145,7 +2144,6 @@ def test_pause_job(request_type, transport: str = "grpc"):
21452144
time_zone="time_zone_value",
21462145
state=job.Job.State.ENABLED,
21472146
legacy_app_engine_cron=True,
2148-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
21492147
)
21502148
response = client.pause_job(request)
21512149

@@ -2394,7 +2392,6 @@ def test_resume_job(request_type, transport: str = "grpc"):
23942392
time_zone="time_zone_value",
23952393
state=job.Job.State.ENABLED,
23962394
legacy_app_engine_cron=True,
2397-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
23982395
)
23992396
response = client.resume_job(request)
24002397

@@ -2643,7 +2640,6 @@ def test_run_job(request_type, transport: str = "grpc"):
26432640
time_zone="time_zone_value",
26442641
state=job.Job.State.ENABLED,
26452642
legacy_app_engine_cron=True,
2646-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
26472643
)
26482644
response = client.run_job(request)
26492645

@@ -3229,7 +3225,6 @@ def test_get_job_rest(request_type):
32293225
time_zone="time_zone_value",
32303226
state=job.Job.State.ENABLED,
32313227
legacy_app_engine_cron=True,
3232-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
32333228
)
32343229

32353230
# Wrap the value into a proper Response obj
@@ -3561,7 +3556,6 @@ def test_create_job_rest(request_type):
35613556
time_zone="time_zone_value",
35623557
state=gcs_job.Job.State.ENABLED,
35633558
legacy_app_engine_cron=True,
3564-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
35653559
)
35663560

35673561
# Wrap the value into a proper Response obj
@@ -3966,7 +3960,6 @@ def test_update_job_rest(request_type):
39663960
time_zone="time_zone_value",
39673961
state=gcs_job.Job.State.ENABLED,
39683962
legacy_app_engine_cron=True,
3969-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
39703963
)
39713964

39723965
# Wrap the value into a proper Response obj
@@ -4555,7 +4548,6 @@ def test_pause_job_rest(request_type):
45554548
time_zone="time_zone_value",
45564549
state=job.Job.State.ENABLED,
45574550
legacy_app_engine_cron=True,
4558-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
45594551
)
45604552

45614553
# Wrap the value into a proper Response obj
@@ -4829,7 +4821,6 @@ def test_resume_job_rest(request_type):
48294821
time_zone="time_zone_value",
48304822
state=job.Job.State.ENABLED,
48314823
legacy_app_engine_cron=True,
4832-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
48334824
)
48344825

48354826
# Wrap the value into a proper Response obj
@@ -5105,7 +5096,6 @@ def test_run_job_rest(request_type):
51055096
time_zone="time_zone_value",
51065097
state=job.Job.State.ENABLED,
51075098
legacy_app_engine_cron=True,
5108-
pubsub_target=target.PubsubTarget(topic_name="topic_name_value"),
51095099
)
51105100

51115101
# Wrap the value into a proper Response obj

0 commit comments

Comments
 (0)