Repository navigation

Commit 574e5eb

authored and

committed

quic: halt conn goroutines on close when listener exits early

Endpoint.Close could return with conn goroutines still running if the endpoint's PacketConn was closed prior to the last conn exiting. (Normally the last conn to exit closes the PacketConn.) Clean up any stray conns before returning. Change-Id: I444f7dbb1e7b194c74a1ff8025abb4346a6a6964 Reviewed-on: https://go-review.googlesource.com/c/net/+/801881 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Nicholas Husin <nsh@golang.org> Auto-Submit: Damien Neil <dneil@google.com> Reviewed-by: Nicholas Husin <husin@google.com>

1 parent 0da447f commit 574e5ebCopy full SHA for 574e5eb

1 file changed

quic
- endpoint.go

`‎quic/endpoint.go‎`

-Original file line number
+Diff line change
 	select {
 	case <-e.closec:
 	case <-ctx.Done():
 -		for _, c := range conns {
 -			c.exit()
 -		}
 -		return ctx.Err()
+	}
 -	return nil
 +	for _, c := range conns {
 +		c.exit()
 +	}
 +	return ctx.Err() // nil if context hasn't expired
+}
 // Accept waits for and returns the next connection.

Comments

(0)