Skip to content

Commit 6642f9f

Browse files
committed
BAEL-19699: Fix core-java-concurrency-basic unit tests
1 parent e984ba6 commit 6642f9f

4 files changed

Lines changed: 28 additions & 16 deletions

File tree

‎core-java-modules/core-java-concurrency-basic/src/test/java/com/baeldung/concurrent/threadsafety/CounterUnitTest.java‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,11 @@ public void whenCalledIncrementCounter_thenCorrect() throws Exception {
1818
Counter counter = new Counter();
1919
Future<Integer> future1 = (Future<Integer>) executorService.submit(new CounterCallable(counter));
2020
Future<Integer> future2 = (Future<Integer>) executorService.submit(new CounterCallable(counter));
21-
22-
assertThat(future1.get()).isEqualTo(1);
23-
assertThat(future2.get()).isEqualTo(2);
21+
22+
// Just to make sure both are completed
23+
future1.get();
24+
future2.get();
25+
26+
assertThat(counter.getCounter()).isEqualTo(2);
2427
}
2528
}

‎core-java-modules/core-java-concurrency-basic/src/test/java/com/baeldung/concurrent/threadsafety/ExtrinsicLockCounterUnitTest.java‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,11 @@ public void whenCalledIncrementCounter_thenCorrect() throws Exception {
1818
ExtrinsicLockCounter counter = new ExtrinsicLockCounter();
1919
Future<Integer> future1 = (Future<Integer>) executorService.submit(new ExtrinsicLockCounterCallable(counter));
2020
Future<Integer> future2 = (Future<Integer>) executorService.submit(new ExtrinsicLockCounterCallable(counter));
21-
22-
assertThat(future1.get()).isEqualTo(1);
23-
assertThat(future2.get()).isEqualTo(2);
21+
22+
// Just to make sure both are completed
23+
future1.get();
24+
future2.get();
25+
26+
assertThat(counter.getCounter()).isEqualTo(2);
2427
}
2528
}

‎core-java-modules/core-java-concurrency-basic/src/test/java/com/baeldung/concurrent/threadsafety/ReentrantLockCounterUnitTest.java‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,18 @@
1111
import static org.assertj.core.api.Assertions.assertThat;
1212

1313
public class ReentrantLockCounterUnitTest {
14-
14+
1515
@Test
1616
public void whenCalledIncrementCounter_thenCorrect() throws Exception {
1717
ExecutorService executorService = Executors.newFixedThreadPool(2);
1818
ReentrantLockCounter counter = new ReentrantLockCounter();
1919
Future<Integer> future1 = (Future<Integer>) executorService.submit(new ReentrantLockCounterCallable(counter));
2020
Future<Integer> future2 = (Future<Integer>) executorService.submit(new ReentrantLockCounterCallable(counter));
21-
22-
assertThat(future1.get()).isEqualTo(1);
23-
assertThat(future2.get()).isEqualTo(2);
21+
22+
// Just to make sure both are completed
23+
future1.get();
24+
future2.get();
25+
26+
assertThat(counter.getCounter()).isEqualTo(2);
2427
}
2528
}

‎core-java-modules/core-java-concurrency-basic/src/test/java/com/baeldung/concurrent/threadsafety/ReentrantReadWriteLockCounterUnitTest.java‎

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,19 @@
1111
import static org.assertj.core.api.Assertions.assertThat;
1212

1313
public class ReentrantReadWriteLockCounterUnitTest {
14-
14+
1515
@Test
1616
public void whenCalledIncrementCounter_thenCorrect() throws Exception {
1717
ExecutorService executorService = Executors.newFixedThreadPool(2);
1818
ReentrantReadWriteLockCounter counter = new ReentrantReadWriteLockCounter();
19-
Future<Integer> future1 = (Future<Integer>) executorService.submit(new ReentranReadWriteLockCounterCallable(counter));
20-
Future<Integer> future2 = (Future<Integer>) executorService.submit(new ReentranReadWriteLockCounterCallable(counter));
19+
Future<Integer> future1 = (Future<Integer>) executorService.submit(new ReentranReadWriteLockCounterCallable(counter));
20+
Future<Integer> future2 = (Future<Integer>) executorService.submit(new ReentranReadWriteLockCounterCallable(counter));
21+
22+
// Just to make sure both are completed
23+
future1.get();
24+
future2.get();
2125

22-
assertThat(future2.get()).isEqualTo(2);
23-
assertThat(future1.get()).isEqualTo(1);
26+
assertThat(counter.getCounter()).isEqualTo(2);
2427
}
25-
28+
2629
}

0 commit comments

Comments
 (0)