Comments before parameters interfere with argument name resolution

@BekaValentine

let obj = {
    x: 1
};

function func_7(/**/ o) {
    return o;
}

func_7(obj).x;
//          ^ defined: 2

This test fails (but should pass) because the comment steals the parameter's lunch.

🎩 @BekaValentine

The problem with this one is that the comment before o is a child of the parameter list that's distinct from the parameter itself. So the comment is child 1 while the param is child 2. The lookup on on x goes through the fall func_7(obj), which sets up a scope where obj is the 1th argument, and the parameter list sets up a lookup on those arguments based on the position of the child. Except in this case, o is not the 1th child, so it resolves to the wrong place -- the non-existent 2th argument of the call.

I can't see any way to fix this within the current tree-sitter framework.

The github/stack-graphs repository is no longer being maintained. As per #502, I'm closing all issues and pull requests before archiving the repository.

Navigation Menu

Repository navigation

Comments before parameters interfere with argument name resolution #371

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Comments before parameters interfere with argument name resolution #371

Description

Activity

BekaValentine commented on Jan 29, 2024

CleanCut commented on Sep 9, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions