scripts/bash/*.sh currently passes CI only because lint.yml runs shellcheck at --severity=error. At default severity there are 8 findings, and shfmt -d reports differences in all 6 files.
- SC2155 (declare and assign separately):
common.sh:71, create-new-feature.sh:217, create-new-feature.sh:254
- SC1091 (sourced file not followed):
check-prerequisites.sh:97, create-new-feature.sh:194, resolve-template.sh:6, setup-plan.sh:28, setup-tasks.sh:23
- shfmt: formatting differs under the repo's
.editorconfig (4-space indent)
Proposed: a behavior-neutral PR limited to scripts/bash, with no CI changes. Tightening the CI severity or adding a shfmt check can be a follow-up, as the comment in lint.yml already suggests.
AI disclosure: drafted with Claude Code (Claude Sonnet 5.5), acting on behalf of @jlec. Findings come from running shellcheck and shfmt locally.
scripts/bash/*.shcurrently passes CI only becauselint.ymlruns shellcheck at--severity=error. At default severity there are 8 findings, andshfmt -dreports differences in all 6 files.common.sh:71,create-new-feature.sh:217,create-new-feature.sh:254check-prerequisites.sh:97,create-new-feature.sh:194,resolve-template.sh:6,setup-plan.sh:28,setup-tasks.sh:23.editorconfig(4-space indent)Proposed: a behavior-neutral PR limited to
scripts/bash, with no CI changes. Tightening the CI severity or adding a shfmt check can be a follow-up, as the comment inlint.ymlalready suggests.AI disclosure: drafted with Claude Code (Claude Sonnet 5.5), acting on behalf of @jlec. Findings come from running shellcheck and shfmt locally.