Repository navigation
[dead-code] chore: remove dead functions — 5 functions removed #65340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pelikhan
merged 4 commits into
main
from
chore/remove-dead-functions-37132019179-9e8280d5463af600
Oct 3, 2026
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fd9d3d5
chore: remove dead functions — 5 functions removed
github-actions[bot] d4f6160
Merge branch 'main' into chore/remove-dead-functions-37132019179-9e82…
github-actions[bot] 8404eeb
fix: preserve exported log parser bootstrap API
Copilot 60551fc
Apply remaining changes
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing
GetLogParserBootstrapis a public API break for any downstream code importingpkg/workflow, so this is not a safe "dead code" deletion.💡 Why this blocks merge
GetLogParserBootstrapis exported, andpkg/workflow/README.mdstill lists it as part of the package surface. Internal callsites being gone only proves it is dead inside this repo; external consumers compiling againstgithub.com/github/gh-aw/pkg/workflowwill now fail at build time.Please either keep a deprecated shim that preserves the symbol (it can keep returning ""), or treat this as an intentional breaking change with the corresponding release-note/API-compat path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restored the original exported GetLogParserBootstrap() string getter in 8404eeb, preserving its empty-string return value. Added a regression test; the full workflow package test suite passes. This cleanup no longer removes the public symbol.