[lint-monster] LintMonster: guard direct slice and string indexing findings #67325

Daily custom lint findings

make golint-custom reported 1,756 direct slice or string indexing findings. The highest-volume areas include pkg/parser/schedule_parser.go (40), pkg/workflow/js.go (39), pkg/workflow/trigger_parser.go (32), pkg/cli/update_actions_content_refs.go (32), and pkg/workflow/expression_parser.go (26). Findings also occur in pkg/linters/ and other pkg/ areas.

Representative diagnostic:

• pkg/logger/logger.go:55: direct slice indexing without a bounds check for basePaletteColors[idx].

Remediation

• Work only on the direct slice/string indexing findings from this lint run.
• Inspect each access and make its safety explicit with a narrow bounds guard, a checked helper, or a small refactor that preserves behavior.
• Where a custom analyzer misses an existing guard, improve that analyzer narrowly and add or update focused analysistest coverage; do not suppress the rule broadly.
• Keep edits minimal and scoped to the listed findings.
• Run make fmt after Go edits, then validate with make golint-custom.

Expected outcome: remove the indexing diagnostics in this group while preserving the existing behavior and handling malformed or unexpected input safely.

Generated by 🧌 LintMonster · codex · gpt60 · 189.5 AIC · ⌖ 29.5 AIC · ⊞ 15.5K · ◷

• expires on Oct 16, 2026, 6:56 PM UTC-08:00