Skip to content

[deep-report] Introduce GuardPolicyMap / RawActionSteps named type aliases for repeated map[string]any / []any shapes #67203

Description

@github-actions

Description

The same map[string]any shape for guard-policy config is independently re-declared as a field type in 5 locations: pkg/workflow/mcp_renderer_types.go:21,94,131, pkg/workflow/mcp_config_types.go:54, and pkg/workflow/tools_types.go:530 — confirmed via direct grep of all 5 sites. Separately, raw GitHub Actions step passthrough (PreSteps/Steps/PreAgentSteps/PostSteps in frontmatter_types.go:413-416, plus 3 more sites) is independently typed as []any in 8 places; this one is correctly dynamic (confirmed via compiler_main_job_helpers.go's re-serialization to YAML) but the "this is intentional passthrough" intent isn't visible at the type level.

Expected Impact

A single named type documents each concept once; if guard-policy config ever grows real structure there's one declaration to change instead of five, and the step-passthrough alias makes the "intentionally untyped YAML" decision visible without relying solely on a comment on one of the eight fields.

Suggested Fix

Introduce type GuardPolicyMap map[string]any and type RawActionSteps []any type aliases and use them consistently in place of the repeated raw map/slice literals.

Suggested Agent

General Go-focused coding agent (mechanical, low-risk retype).

Estimated Effort

Quick (< 1 hour)

Data Source

Typist — Go Type Consistency Analysis, discussion #67180 (2026-10-09), Category 2 / Priority 3 item #7. Live-verified via direct grep of all declaration sites before filing.

Generated by 🔬 Deep Report · claude · agent · 270.5 AIC · ⌖ 8.95 AIC · ⊞ 7.1K · ◷

  • expires on Oct 11, 2026, 4:47 AM UTC-08:00

Activity

  1. github-actions commented on Oct 11, 2026

    @github-actions
    ContributorAuthor

    🍪 Issue Monster selected this for Copilot

    I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.

    If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.

    Om nom nom! 🍪

    🍪 Om nom nom by Issue Monster · pi · gpt54 · 11.3 AIC · ⌖ 11.5 AIC · ⊞ 12.1K · ◷

  2. github-actions commented on Oct 11, 2026

    @github-actions
    ContributorAuthor

    🍪 Issue Monster selected this for Copilot

    Ive identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.

    If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.

    Om nom nom! 🍪

    🍪 Om nom nom by Issue Monster · pi · gpt54 · 14.3 AIC · ⌖ 8.83 AIC · ⊞ 12.1K · ◷

  3. github-actions commented on Oct 11, 2026

    @github-actions
    ContributorAuthor

    🍪 Issue Monster selected this for Copilot

    I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.

    If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.

    Om nom nom! 🍪

    🍪 Om nom nom by Issue Monster · pi · gpt54 · 13.7 AIC · ⌖ 10.6 AIC · ⊞ 12.2K · ◷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions