Description
pkg/cli/domain_buckets.go:13 defines DomainBuckets{AllowedDomains, BlockedDomains []string} specifically to be embedded by other CLI reporting types (it's already embedded via AnalysisBase elsewhere), but WorkflowDomainsDetail (pkg/cli/domains_command.go:27) independently re-declares the same two fields instead of embedding it — confirmed via direct read.
Expected Impact
One definition of "what an allow/block domain pair looks like" across CLI domain-reporting types, instead of a second hand-maintained copy.
Suggested Fix
Embed DomainBuckets in WorkflowDomainsDetail in place of its own AllowedDomains/BlockedDomains fields.
Suggested Agent
General Go-focused coding agent.
Estimated Effort
Quick (30-60 minutes)
Data Source
Typist — Go Type Consistency Analysis, discussion #67180 (2026-10-09), Cluster 4 / Priority 3 item #6. Live-verified via direct source read of domain_buckets.go and domains_command.go before filing.
Generated by 🔬 Deep Report · claude · agent · 270.5 AIC · ⌖ 8.95 AIC · ⊞ 7.1K · ◷
Description
pkg/cli/domain_buckets.go:13definesDomainBuckets{AllowedDomains, BlockedDomains []string}specifically to be embedded by other CLI reporting types (it's already embedded viaAnalysisBaseelsewhere), butWorkflowDomainsDetail(pkg/cli/domains_command.go:27) independently re-declares the same two fields instead of embedding it — confirmed via direct read.Expected Impact
One definition of "what an allow/block domain pair looks like" across CLI domain-reporting types, instead of a second hand-maintained copy.
Suggested Fix
Embed
DomainBucketsinWorkflowDomainsDetailin place of its ownAllowedDomains/BlockedDomainsfields.Suggested Agent
General Go-focused coding agent.
Estimated Effort
Quick (30-60 minutes)
Data Source
Typist — Go Type Consistency Analysis, discussion #67180 (2026-10-09), Cluster 4 / Priority 3 item #6. Live-verified via direct source read of
domain_buckets.goanddomains_command.gobefore filing.