Skip to content

[file-diet] Refactor pkg/cli/add_workflow_resolution.go (1214 lines) #66888

Description

@github-actions

Overview

pkg/cli/add_workflow_resolution.go is 1214 lines (largest non-test Go file in pkg/; threshold 800). No add_workflow_resolution_test.go exists.

Proposed splits

  1. add_workflow_resolution.go (~350 LOC): ResolveWorkflows, spec parsing, workflow-spec resolution, bootstrap profile selection.
  2. add_workflow_local_package.go (~420 LOC): resolveLocalRepositoryPackage*, manifest nodes, wildcard includes, installable normalization/validation.
  3. add_workflow_package_assets.go (~200 LOC): skill/agent scanning, appendLocalRepositoryPackageWorkflowSpecs.
  4. add_workflow_remote_package.go (~100 LOC): appendRepositoryPackageWorkflowSpecs, appendRepositoryPackageExtensionSpecs.
  5. add_workflow_wildcard.go (~150 LOC): expandLocalWildcard*, checkWorkflowHasDispatchFromContent, resolveAddWorkflowSpecAndContent.

Tests

Add a test file per new file (>80% coverage): manifest/include resolution, path-escape validation, skill/agent scanning, wildcard expansion, bootstrap profile selection.

Acceptance Criteria

  • Split into 5 files, each under 500 lines
  • make test-unit, make lint, make build pass
  • No public API change

Priority: Medium · Effort: Medium

Generated by 🧹 Daily File Diet · copilot · auto · 21 AIC · ⌖ 0.732 AIC · ⊞ 10.6K · ◷

  • expires on Oct 10, 2026, 4:59 AM UTC-08:00

Activity

  1. github-actions commented on Oct 10, 2026

    @github-actions
    ContributorAuthor

    This issue was automatically closed because it expired on 2026-10-10T12:59:53.112Z.

    Closed by Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions