Skip to content

[AW Top 10] 03 Honor soft-skip targets in two safe-output handlers #66487

Description

@github-actions

Priority 3/10 | 1 source issues | Impact 3/5 | Confidence 5/5 | Effort 1/5

One assignment, one coherent fix

The set_issue_type and submit_pull_request_review handlers discard the shouldFail flag from resolveTarget and report a hard failure. A triggering target outside its context therefore fails the whole safe_outputs job.

Implementation scope

Propagate the soft skip as a skipped success in set_issue_type.cjs and in the handleWithRegistry path of submit_pr_review.cjs, mirroring the correct pattern already present elsewhere in the same file.

Done when

  • A regression test shows a soft-skipped target returns a skipped result instead of a failure for both handlers.
  • Hard target errors still fail the job.

Why now

The report cites exact lines that I confirmed in the current code. The fix is small and removes a real failure for any workflow using the default triggering target.

AW source issues and corroborating reports

#66054

No corroborating AW discussion; evidence comes from the source issues.

Unchanged AW sources close only after this summary is completed. Newer source activity and not-planned retirement do not trigger source closure. Assigned summaries are frozen; unassign to allow reclustering.

Generated by AW Essential Issue Clustering · copilot · auto · 82.7 AIC · ⌖ 21.8 AIC · ⊞ 8.9K · ◷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

agentic-workflowsautomationaw-essentialEssential AW-generated issue clusters: assign one to resolve related findingscookieIssue Monster Loves Cookies!

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions